-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): global copy paste #6856
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
sjelfull
force-pushed
the
feat/global-copy-paste
branch
from
June 5, 2024 12:09
d27462a
to
644d048
Compare
No changes to documentation |
Component Testing Report Updated Jul 11, 2024 7:30 PM (UTC)
|
skogsmaskin
force-pushed
the
feat/global-copy-paste
branch
from
June 10, 2024 12:59
0e67061
to
7231f47
Compare
touches edx-1553 Signed-off-by: Fred Carlsen <[email protected]>
fixes edx-1558 Signed-off-by: Fred Carlsen <[email protected]>
fixes edx-1555 Signed-off-by: Fred Carlsen <[email protected]>
fixes edx-1560 Signed-off-by: Fred Carlsen <[email protected]>
Signed-off-by: Fred Carlsen <[email protected]>
Signed-off-by: Fred Carlsen <[email protected]>
ricokahler
force-pushed
the
feat/global-copy-paste
branch
from
July 11, 2024 19:13
b915dae
to
768a5bd
Compare
cngonzalez
approved these changes
Jul 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, all!!
This was referenced Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces global copy & pasting of fields and documents. You can copy and paste either through Ctrl-C/Ctrl-V when focused on a field, or by using the Field Action / Document Context Action menu (the one in the right corner, where Inspect and Review Changes.
CleanShot.2024-07-01.at.16.00.45.mp4
We have included a global keydown event listener that handles copy and paste events. They will not trigger if any of these is true:
window.getSelection()
)[]
)Keyboard shortcuts
The keyboard shortcuts is limited to these fields:
Field actions
Using fields actions you can copy and paste from any field that has a field action menu available. This currently excludes:
What to review
Testing
Notes for release