fix(test-studio): add repro case for using server actions with custom publish document action #6945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
No changes to documentation |
|
Component Testing Report Updated Jun 18, 2024 10:30 AM (UTC)
|
…lication Co-authored-by: Bjørge Næss <[email protected]>
juice49
force-pushed
the
sdx-1407/patch-before-publish
branch
from
26ffe77
to
3030bfe
Compare
juice49
previously approved these changes
Jun 18, 2024
…blishing documents Co-authored-by: Bjørge Næss <[email protected]>
juice49
force-pushed
the
sdx-1407/patch-before-publish
branch
from
3030bfe
to
890164e
Compare
juice49
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This branch removes usage of the
ifDraftRevisionIdoptimistic lock when publishing documents using the Actions API. For custom publish document actions,snapshots.draft._revmay be stale, which means theifDraftRevisionIdoptimistic lock cannot currently be used.This is less safe, because it means it's technically possible for a user publishing a document via Studio to cause the publication of a draft that has not yet been synced to them. However, it's important to note this same issue exists with the Mutations API integration today. When the underlying staleness bug is fixed in the future, we should switch
ifDraftRevisionIdback on.We still make use of
ifPublishedRevisionIdto ensure concurrent publish action invocations do not override each other.What to review
That removing the
ifDraftRevisionIdoptimistic lock does not introduce any failure points that do not already exist in the Mutations API integration.Testing
Ensure that the "Custom publish that sets publishedAt to now" action (
test/structure/input-debug;documentActionsTest) works as expected.