Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): clickable links in comment message #7093

Merged
merged 7 commits into from
Jul 12, 2024
Merged

Conversation

hermanwikner
Copy link
Member

@hermanwikner hermanwikner commented Jul 8, 2024

Description

This pull request makes links in comment messages clickable by transforming text that starts with 'http://', 'https://', or 'www' into anchor tags.

links

What to Review

  • Ensure that links become clickable in the comment message.
  • A simple middleware pattern was created to transform the children in the comment message. At this point, it is not very necessary as we are only transforming links, but it allows for easily adding further transformations of the children in the future. Does it make sense?

Testing

  • Unit test the transformChildren logic. Are there any cases missing that the test should cover?

Notes for Release

Make links in comment messages clickable.

Copy link

vercel bot commented Jul 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 11, 2024 3:00pm
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 11, 2024 3:00pm
test-compiled-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 11, 2024 3:00pm
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 11, 2024 3:00pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 11, 2024 3:00pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Jul 11, 2024 3:00pm

Copy link
Contributor

github-actions bot commented Jul 8, 2024

No changes to documentation

Copy link
Contributor

github-actions bot commented Jul 8, 2024

Component Testing Report Updated Jul 11, 2024 3:08 PM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 38s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 7s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 27s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 33s 11 7 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 15s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 9s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 51s 1 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 36s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 19s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 6s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 7s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 22s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 16s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 1m 7s 21 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 1m 40s 30 0 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 20s 3 0 0

Copy link
Contributor

@RitaDias RitaDias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants