Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sanity): #TEMPORARY #DELETE handle versions in DocumentPaneProvider #7151

Merged
merged 1 commit into from
Jul 14, 2024

Conversation

juice49
Copy link
Contributor

@juice49 juice49 commented Jul 14, 2024

Description

This is a temporary change that allows document versions to be viewed and edited. It works by modifying DocumentPaneProvider to treat the version document (e.g. someVersion.x) as a published document in live edit mode if a bundle is checked out and the document being viewed exists in that bundle.

This is not the proper solution—hence __SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED_LIVE_EDIT_OVERRIDE—and should be reverted (and ideally the commit removed altogether) once we have a better one in place.

Note: the appearance of the "live" badge in the document pane footer lags. To be precise, it seems to reflect the last viewed document rather than the one currently being viewed. I think we can ignore this for now. The live edit functionality itself works as intended.

Copy link

vercel bot commented Jul 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 14, 2024 4:49pm
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 14, 2024 4:49pm
test-compiled-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 14, 2024 4:49pm
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 14, 2024 4:49pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 14, 2024 4:49pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Jul 14, 2024 4:49pm

Copy link
Contributor

No changes to documentation

@juice49 juice49 marked this pull request as ready for review July 14, 2024 21:28
@juice49 juice49 requested a review from a team as a code owner July 14, 2024 21:28
@juice49 juice49 requested review from ricokahler and removed request for a team and ricokahler July 14, 2024 21:28
@juice49 juice49 merged commit 35eeeb2 into corel Jul 14, 2024
39 of 42 checks passed
@juice49 juice49 deleted the feat/corel/live-edit-hack branch July 14, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant