feat(sanity): #TEMPORARY #DELETE handle versions in DocumentPaneProvider
#7151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
|
No changes to documentation |
juice49
requested review from
ricokahler
and removed request for
a team and
ricokahler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a temporary change that allows document versions to be viewed and edited. It works by modifying
DocumentPaneProviderto treat the version document (e.g.someVersion.x) as a published document in live edit mode if a bundle is checked out and the document being viewed exists in that bundle.This is not the proper solution—hence
__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED_LIVE_EDIT_OVERRIDE—and should be reverted (and ideally the commit removed altogether) once we have a better one in place.Note: the appearance of the "live" badge in the document pane footer lags. To be precise, it seems to reflect the last viewed document rather than the one currently being viewed. I think we can ignore this for now. The live edit functionality itself works as intended.