Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sanity): avoid fetching in a loop #7152

Merged
merged 1 commit into from
Jul 15, 2024
Merged

fix(sanity): avoid fetching in a loop #7152

merged 1 commit into from
Jul 15, 2024

Conversation

juice49
Copy link
Contributor

@juice49 juice49 commented Jul 14, 2024

Description

I know this code is temporary, but I noticed it seems to be fetching repeatedly the entire time it's mounted. Here's a tiny 🤏 bandaid to stop that.

Copy link

vercel bot commented Jul 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 14, 2024 9:51pm
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 14, 2024 9:51pm
test-compiled-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 14, 2024 9:51pm
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 14, 2024 9:51pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 14, 2024 9:51pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Jul 14, 2024 9:51pm

Copy link
Contributor

No changes to documentation

Copy link
Contributor

@RitaDias RitaDias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still thinking this is something we'll need to remove and move to the releases bundle. Not quite sure what it'll happen but this sounds good!

@RitaDias RitaDias removed the request for review from pedrobonamin July 15, 2024 08:04
@juice49
Copy link
Contributor Author

juice49 commented Jul 15, 2024

Thanks @RitaDias. I fully agree 🙂.

@juice49 juice49 merged commit 6261ca1 into corel Jul 15, 2024
37 of 41 checks passed
@juice49 juice49 deleted the fix/corel/fetch-loop branch July 15, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants