Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(releases): sorting release overview table #7159

Merged
merged 5 commits into from
Jul 18, 2024
Merged

feat(releases): sorting release overview table #7159

merged 5 commits into from
Jul 18, 2024

Conversation

jordanl17
Copy link
Member

@jordanl17 jordanl17 commented Jul 15, 2024 •
edited
Loading

Description

  • Creates a <Table /> that is used in ReleasesOverview and ReleaseSummary
  • Rename of a few components in the release plugin, eg ReleaseOverview is now ReleaseSummary to avoid confusion
  • Update to the confirm document version delete dialog
  • Other small copy changes

What to review

Testing

  • Tests updated for ReleasesOverview
  • Will add testing in a fast-follow for ReleaseSummary since this requires more mocking

Notes for release

N/A

@vercel Vercel
Copy link

vercel bot commented Jul 15, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 18, 2024 10:49am
performance-studio ✅ Ready (Inspect) Visit Preview Jul 18, 2024 10:49am
test-compiled-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 18, 2024 10:49am
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 18, 2024 10:49am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 18, 2024 10:49am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Jul 18, 2024 10:49am

@jordanl17 jordanl17 changed the title Corel 30 overview sorting feat(releases): sorting release overview table Jul 15, 2024
Base automatically changed from corel-44-context to corel July 16, 2024 09:34
@github-actions GitHub Actions
Copy link
Contributor

No changes to documentation

@jordanl17
refactor(releases): default table data type of unknown; rename of som…
20578fb 
…e variables; improved types for TableProvider
@jordanl17 jordanl17 requested a review from juice49 July 18, 2024 12:54
juice49
juice49 approved these changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@juice49 juice49 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@jordanl17 jordanl17 merged commit 5f2ea45 into corel Jul 18, 2024
39 of 41 checks passed
@jordanl17 jordanl17 deleted the corel-30-overview-sorting branch July 18, 2024 13:42
bjoerge pushed a commit that referenced this pull request Jul 24, 2024
@jordanl17 @bjoerge
feat(releases): sorting release overview table (#7159)
447c5e2 
* feat(releases): sorting releases table with new Table component

* fix(releases): fixing sanity require for DocumentPerspectiveMenu.test

* refactor(releases): clarifying generic names; minor tidies to naming

* refactor(releases): default table data type of unknown; rename of some variables; improved types for TableProvider

* refactor(releases): default table data type of unknown; rename of some variables; improved types for TableProvider
bjoerge pushed a commit that referenced this pull request Jul 24, 2024
@jordanl17 @bjoerge
feat(releases): sorting release overview table (#7159)
f73b608 
* feat(releases): sorting releases table with new Table component

* fix(releases): fixing sanity require for DocumentPerspectiveMenu.test

* refactor(releases): clarifying generic names; minor tidies to naming

* refactor(releases): default table data type of unknown; rename of some variables; improved types for TableProvider

* refactor(releases): default table data type of unknown; rename of some variables; improved types for TableProvider
bjoerge pushed a commit that referenced this pull request Jul 30, 2024
@jordanl17 @bjoerge
feat(releases): sorting release overview table (#7159)
103e11c 
* feat(releases): sorting releases table with new Table component

* fix(releases): fixing sanity require for DocumentPerspectiveMenu.test

* refactor(releases): clarifying generic names; minor tidies to naming

* refactor(releases): default table data type of unknown; rename of some variables; improved types for TableProvider

* refactor(releases): default table data type of unknown; rename of some variables; improved types for TableProvider
bjoerge pushed a commit that referenced this pull request Jul 30, 2024
@jordanl17 @bjoerge
feat(releases): sorting release overview table (#7159)
d501679 
* feat(releases): sorting releases table with new Table component

* fix(releases): fixing sanity require for DocumentPerspectiveMenu.test

* refactor(releases): clarifying generic names; minor tidies to naming

* refactor(releases): default table data type of unknown; rename of some variables; improved types for TableProvider

* refactor(releases): default table data type of unknown; rename of some variables; improved types for TableProvider
bjoerge pushed a commit that referenced this pull request Aug 2, 2024
@jordanl17 @bjoerge
feat(releases): sorting release overview table (#7159)
9a72ba2 
* feat(releases): sorting releases table with new Table component

* fix(releases): fixing sanity require for DocumentPerspectiveMenu.test

* refactor(releases): clarifying generic names; minor tidies to naming

* refactor(releases): default table data type of unknown; rename of some variables; improved types for TableProvider

* refactor(releases): default table data type of unknown; rename of some variables; improved types for TableProvider
juice49 pushed a commit that referenced this pull request Aug 4, 2024
@jordanl17 @juice49
feat(releases): sorting release overview table (#7159)
bbc6e46 
* feat(releases): sorting releases table with new Table component

* fix(releases): fixing sanity require for DocumentPerspectiveMenu.test

* refactor(releases): clarifying generic names; minor tidies to naming

* refactor(releases): default table data type of unknown; rename of some variables; improved types for TableProvider

* refactor(releases): default table data type of unknown; rename of some variables; improved types for TableProvider
juice49 pushed a commit that referenced this pull request Aug 6, 2024
@jordanl17 @juice49
feat(releases): sorting release overview table (#7159)
4360ac6 
* feat(releases): sorting releases table with new Table component

* fix(releases): fixing sanity require for DocumentPerspectiveMenu.test

* refactor(releases): clarifying generic names; minor tidies to naming

* refactor(releases): default table data type of unknown; rename of some variables; improved types for TableProvider

* refactor(releases): default table data type of unknown; rename of some variables; improved types for TableProvider
bjoerge pushed a commit that referenced this pull request Aug 7, 2024
@jordanl17 @bjoerge
feat(releases): sorting release overview table (#7159)
8f23e9b 
* feat(releases): sorting releases table with new Table component

* fix(releases): fixing sanity require for DocumentPerspectiveMenu.test

* refactor(releases): clarifying generic names; minor tidies to naming

* refactor(releases): default table data type of unknown; rename of some variables; improved types for TableProvider

* refactor(releases): default table data type of unknown; rename of some variables; improved types for TableProvider
bjoerge pushed a commit that referenced this pull request Aug 16, 2024
@jordanl17 @bjoerge
feat(releases): sorting release overview table (#7159)
bd6e14f 
* feat(releases): sorting releases table with new Table component

* fix(releases): fixing sanity require for DocumentPerspectiveMenu.test

* refactor(releases): clarifying generic names; minor tidies to naming

* refactor(releases): default table data type of unknown; rename of some variables; improved types for TableProvider

* refactor(releases): default table data type of unknown; rename of some variables; improved types for TableProvider
bjoerge pushed a commit that referenced this pull request Aug 20, 2024
@jordanl17 @bjoerge
feat(releases): sorting release overview table (#7159)
d471c88 
* feat(releases): sorting releases table with new Table component

* fix(releases): fixing sanity require for DocumentPerspectiveMenu.test

* refactor(releases): clarifying generic names; minor tidies to naming

* refactor(releases): default table data type of unknown; rename of some variables; improved types for TableProvider

* refactor(releases): default table data type of unknown; rename of some variables; improved types for TableProvider
bjoerge pushed a commit that referenced this pull request Aug 20, 2024
@jordanl17 @bjoerge
feat(releases): sorting release overview table (#7159)
f65d05a 
* feat(releases): sorting releases table with new Table component

* fix(releases): fixing sanity require for DocumentPerspectiveMenu.test

* refactor(releases): clarifying generic names; minor tidies to naming

* refactor(releases): default table data type of unknown; rename of some variables; improved types for TableProvider

* refactor(releases): default table data type of unknown; rename of some variables; improved types for TableProvider
bjoerge pushed a commit that referenced this pull request Aug 20, 2024
@jordanl17 @bjoerge
feat(releases): sorting release overview table (#7159)
3e62f82 
* feat(releases): sorting releases table with new Table component

* fix(releases): fixing sanity require for DocumentPerspectiveMenu.test

* refactor(releases): clarifying generic names; minor tidies to naming

* refactor(releases): default table data type of unknown; rename of some variables; improved types for TableProvider

* refactor(releases): default table data type of unknown; rename of some variables; improved types for TableProvider
RitaDias pushed a commit that referenced this pull request Aug 23, 2024
@jordanl17 @RitaDias
feat(releases): sorting release overview table (#7159)
eff5421 
* feat(releases): sorting releases table with new Table component

* fix(releases): fixing sanity require for DocumentPerspectiveMenu.test

* refactor(releases): clarifying generic names; minor tidies to naming

* refactor(releases): default table data type of unknown; rename of some variables; improved types for TableProvider

* refactor(releases): default table data type of unknown; rename of some variables; improved types for TableProvider
RitaDias pushed a commit that referenced this pull request Aug 26, 2024
@jordanl17 @RitaDias
feat(releases): sorting release overview table (#7159)
e80bdee 
* feat(releases): sorting releases table with new Table component

* fix(releases): fixing sanity require for DocumentPerspectiveMenu.test

* refactor(releases): clarifying generic names; minor tidies to naming

* refactor(releases): default table data type of unknown; rename of some variables; improved types for TableProvider

* refactor(releases): default table data type of unknown; rename of some variables; improved types for TableProvider
juice49 pushed a commit that referenced this pull request Sep 3, 2024
@jordanl17 @juice49
feat(releases): sorting release overview table (#7159)
5735897 
* feat(releases): sorting releases table with new Table component

* fix(releases): fixing sanity require for DocumentPerspectiveMenu.test

* refactor(releases): clarifying generic names; minor tidies to naming

* refactor(releases): default table data type of unknown; rename of some variables; improved types for TableProvider

* refactor(releases): default table data type of unknown; rename of some variables; improved types for TableProvider
RitaDias pushed a commit that referenced this pull request Oct 3, 2024
@jordanl17 @RitaDias
feat(releases): sorting release overview table (#7159)
04db114 
* feat(releases): sorting releases table with new Table component

* fix(releases): fixing sanity require for DocumentPerspectiveMenu.test

* refactor(releases): clarifying generic names; minor tidies to naming

* refactor(releases): default table data type of unknown; rename of some variables; improved types for TableProvider

* refactor(releases): default table data type of unknown; rename of some variables; improved types for TableProvider
juice49 pushed a commit that referenced this pull request Oct 4, 2024
@jordanl17 @juice49
feat(releases): sorting release overview table (#7159)
17f3bec 
* feat(releases): sorting releases table with new Table component

* fix(releases): fixing sanity require for DocumentPerspectiveMenu.test

* refactor(releases): clarifying generic names; minor tidies to naming

* refactor(releases): default table data type of unknown; rename of some variables; improved types for TableProvider

* refactor(releases): default table data type of unknown; rename of some variables; improved types for TableProvider
juice49 pushed a commit that referenced this pull request Oct 7, 2024
@jordanl17 @juice49
feat(releases): sorting release overview table (#7159)
0682fa7 
* feat(releases): sorting releases table with new Table component

* fix(releases): fixing sanity require for DocumentPerspectiveMenu.test

* refactor(releases): clarifying generic names; minor tidies to naming

* refactor(releases): default table data type of unknown; rename of some variables; improved types for TableProvider

* refactor(releases): default table data type of unknown; rename of some variables; improved types for TableProvider
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juice49 juice49 juice49 approved these changes

@bjoerge bjoerge Awaiting requested review from bjoerge

@RitaDias RitaDias Awaiting requested review from RitaDias

@pedrobonamin pedrobonamin Awaiting requested review from pedrobonamin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jordanl17 @juice49