fix(deps): update dependency @sanity/ui to ^2.7.0 #7168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
|
No changes to documentation |
stipsan
force-pushed
the
fix-match-media-tests
branch
from
683cd81
to
2c2f436
Compare
|
Component Testing Report Updated Jul 16, 2024 4:11 PM (UTC)
|
rexxars
approved these changes
Jul 16, 2024
This was referenced Aug 10, 2024
cngonzalez
pushed a commit
that referenced
this pull request
Aug 20, 2024
* fix(deps): update dependency @sanity/ui to ^2.7.0 * chore: fix failing matchMedia tests --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like the reason the #7165 test suite is failing is because a lot of tests call
jest.resetAllMocks(), and since thematchMediamock usesjest.fn().mockImplementationit leads to the implementation later becoming() => undefinedwhen it should always be(query: string) => ({matches: false, media: query, onchange: null, ...rest})Closes #7165