feat(core): add aliases to mitigate context issues #7172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
|
No changes to documentation |
|
Component Testing Report Updated Jul 19, 2024 3:52 PM (UTC)
|
|
Tests seem to be failing, will review when they pass! |
cngonzalez
reviewed
Jul 18, 2024
|
These changes generally make sense to me and I'm sure work smoothly, but I'd feel more comfortable with someone more familiar with our Vite config having a look as well 🙇 |
ricokahler
force-pushed
the
sdx-1471
branch
3 times, most recently
from
8ca1c0d
to
5711f84
Compare
cngonzalez
previously approved these changes
Jul 19, 2024
cngonzalez
approved these changes
Jul 19, 2024
stipsan
pushed a commit
that referenced
this pull request
Jul 22, 2024
* feat(core): add aliases to mitigate context issues * fix(core): use `find` `replacement` syntax for aliases * docs: add TODO comment about improving test
stipsan
pushed a commit
that referenced
this pull request
Jul 22, 2024
* feat(core): add aliases to mitigate context issues * fix(core): use `find` `replacement` syntax for aliases * docs: add TODO comment about improving test
This was referenced Aug 10, 2024
cngonzalez
pushed a commit
that referenced
this pull request
Aug 20, 2024
* feat(core): add aliases to mitigate context issues * fix(core): use `find` `replacement` syntax for aliases * docs: add TODO comment about improving test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request enhances the
sanityReact library's build tooling by adding comprehensive comments and JSDoc annotations to improve maintainability and understanding of the code. Specifically, it elaborates on package exports, conditions, and thegetAliasesfunction. Additionally, it completes the associated test file to ensure thegetAliasesfunction operates correctly in both monorepo and normal build scenarios.Key changes:
aliases.tsto explain the purpose and functionality of the code.aliases.test.tswith test cases for normal builds and monorepo builds.Why these changes were introduced:
What to review
aliases.tsfor accuracy and clarity.aliases.test.tsto ensure they cover the expected scenarios and edge cases.Testing
aliases.test.ts.getAliases.Demo:
aliases.mp4
Notes for release
sanity buildandsanity deployto prevent missing React context issues.