Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add CLI command to open Sanity Learn #7409

Merged
merged 3 commits into from
Oct 14, 2024
Merged

feat: add CLI command to open Sanity Learn #7409

merged 3 commits into from
Oct 14, 2024

Conversation

SimeonGriggs
Copy link
Contributor

Notes for release

Adds a new CLI command sanity learn to open www.sanity.io/learn

@SimeonGriggs SimeonGriggs requested a review from a team as a code owner August 22, 2024 08:39
@SimeonGriggs SimeonGriggs requested review from juice49 and removed request for a team August 22, 2024 08:39
Copy link

vercel bot commented Aug 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 14, 2024 0:38am
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 14, 2024 0:38am
test-compiled-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 14, 2024 0:38am
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 14, 2024 0:38am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 14, 2024 0:38am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Oct 14, 2024 0:38am

Copy link
Contributor

No changes to documentation

Copy link
Contributor

github-actions bot commented Aug 22, 2024

Component Testing Report Updated Oct 14, 2024 12:35 PM (UTC)

✅ All Tests Passed -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 45s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 8s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 30s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 38s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 18s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 10s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 3m 0s 0 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 46s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 41s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 17s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 9s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 26s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 18s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 35s 12 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

Copy link
Contributor

@juice49 juice49 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Simeon, this change looks great! Please can you re-run the tests?

Copy link
Contributor

⚡️ Editor Performance Report

Updated Mon, 14 Oct 2024 12:47:00 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 18.2 efps (55ms) 17.5 efps (57ms) +2ms (+3.6%)
article (body) 54.8 efps (18ms) 63.7 efps (16ms) -3ms (-14.0%)
article (string inside object) 19.2 efps (52ms) 18.0 efps (56ms) +4ms (+6.7%)
article (string inside array) 14.9 efps (67ms) 15.0 efps (67ms) -1ms (-0.7%)
recipe (name) 31.3 efps (32ms) 31.3 efps (32ms) +0ms (-/-%)
recipe (description) 35.7 efps (28ms) 35.7 efps (28ms) +0ms (-/-%)
recipe (instructions) 99.9+ efps (6ms) 99.9+ efps (6ms) +0ms (-/-%)
synthetic (title) 14.9 efps (67ms) 15.2 efps (66ms) -1ms (-1.5%)
synthetic (string inside object) 16.1 efps (62ms) 15.7 efps (64ms) +2ms (+2.4%)

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 55ms 62ms 78ms 147ms 1104ms 13.3s
article (body) 18ms 20ms 22ms 189ms 236ms 5.7s
article (string inside object) 52ms 54ms 65ms 225ms 909ms 8.9s
article (string inside array) 67ms 71ms 80ms 192ms 1825ms 10.0s
recipe (name) 32ms 34ms 44ms 72ms 65ms 9.2s
recipe (description) 28ms 31ms 41ms 89ms 40ms 6.4s
recipe (instructions) 6ms 8ms 9ms 23ms 0ms 3.2s
synthetic (title) 67ms 70ms 75ms 272ms 2216ms 15.9s
synthetic (string inside object) 62ms 65ms 73ms 539ms 2215ms 10.0s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 57ms 61ms 70ms 123ms 1094ms 13.7s
article (body) 16ms 18ms 23ms 105ms 225ms 5.5s
article (string inside object) 56ms 58ms 62ms 178ms 934ms 8.8s
article (string inside array) 67ms 70ms 74ms 215ms 1662ms 9.8s
recipe (name) 32ms 34ms 44ms 67ms 42ms 9.5s
recipe (description) 28ms 31ms 38ms 148ms 60ms 6.3s
recipe (instructions) 6ms 8ms 9ms 10ms 0ms 3.2s
synthetic (title) 66ms 71ms 78ms 226ms 1821ms 15.4s
synthetic (string inside object) 64ms 68ms 72ms 588ms 2345ms 10.4s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

@juice49 juice49 self-requested a review October 14, 2024 15:36
Copy link
Contributor

@juice49 juice49 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition! Thanks (:

@SimeonGriggs SimeonGriggs added this pull request to the merge queue Oct 14, 2024
Merged via the queue into next with commit 1504511 Oct 14, 2024
64 checks passed
@SimeonGriggs SimeonGriggs deleted the cli/learn branch October 14, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants