refactor(sanity, release): rename interface focused components from bundle to release #7469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
|
No changes to documentation |
|
Component Testing Report Updated Sep 10, 2024 8:35 AM (UTC) ✅ All Tests Passed -- expand for details
|
…ewStateObservable
RitaDias
requested review from
ryanbonial,
bjoerge,
juice49,
jordanl17 and
pedrobonamin
and removed request for
a team and
ryanbonial
bjoerge
reviewed
Sep 9, 2024
| @@ -25,15 +25,15 @@ export function getPreviewStateObservable( | |||
| schemaType: SchemaType, | |||
| documentId: string, | |||
| title: ReactNode, | |||
| bundlePerspective?: string, | |||
| perspective?: string, | |||
| @@ -46,7 +50,6 @@ describe('BundleMenuButton', () => { | |||
| _type: 'release', | |||
| archivedAt: undefined, | |||
| title: 'activeBundle', | |||
| slug: 'activeBundle', | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
❗ My plan in the PR was to also move the components to the right folders. However, when I started doing that the tests in releases started failing and I wasn't able to find out why in time, so I kept them where they were and created a related ticket so this doesn't get lost.
I'm on rotation this week and he PR is already pretty big across different files so I want to make sure that this PR doesn't hang for long. I kept the moving folders out of scope.
❓ There are quite a few places within the components where we have const named based on bundles vs releases. We can rename those as well but I feel that the name of the components is more important?
I can rename those, but I wanted to get this larger chunk out of the way
What to review
Overall if naming needs to be re-adjusted