feat(core): specific error when dev server is stopped #7476
Conversation
…dev server stop error
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
|
No changes to documentation |
|
Component Testing Report Updated Sep 30, 2024 2:25 PM (UTC) ✅ All Tests Passed -- expand for details
|
…is only for default vite
| useEffect(() => { | ||
| // no early return to optimize tree-shaking | ||
| if (isViteServer(serverHot)) { | ||
| serverHot.on('vite:ws:disconnect', markDevServerStopped) |
There was a problem hiding this comment.
@juice49 using import.meta.hot.on. In our version of vite (4.x) there is no .off, however there is in 5.x. Don't think it's a big issue here, since restarting the server will trigger a refresh on the client. But does raise a question around us upgrading perhaps... one for another time
There was a problem hiding this comment.
Interesting omission from the v4 API 🤔. Do you have any concerns around creating multiple subscriptions that are never cleaned up?
There was a problem hiding this comment.
I'm not concerned around multiple subscriptions since starting the server again causing a remounting of the entire app, clearing all existing listeners
Added to transform |
|
I checked it out to test, but I'm not sure this is working exactly as intended. As soon as I stop the dev server, an uncaught 
When subsequently navigating elsewhere (with dev server still stopped), I saw the 
|
@juice49 right you are, I'd forgotten to commit the final commit to rename a few things which was causing this. Note however that navigating away from the initial 'dev server stopped' error will still show the dynamic import error. It would be possible to rectify this, but I can't think of how besides complicating the current setup, which doesn't feel appropriate given this is meant to just be an incremental dev experience improvement |
Description
Currently when the dev server is stopped, when the next error is thrown (for example a new lazy bundle is fetched), then an error
failed to fetch dynamic importis thrown and displayed. It doesn't make it clear that this has happened because dev server has gone away.Now, immediately once the dev server is stopped, the studio will show an error boundary stating such.
What to review
DevServerStopped.tsxDevServerStoppedis lazy imported to avoid adding this to the bundle when not in development modeStudioLayout.tsxthrowing the dev server stopped error which is causing in studio error boundary, from where the specific screen is shownTesting
Notes for release