Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix tsc build errors in latest @types/react #7482

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Conversation

stipsan
Copy link
Member

@stipsan stipsan commented Sep 9, 2024

Description

After bumping @sanity/tsdoc, @sanity/pkg-utils and @types/react deps today the main build started to fail:

Error: sanity:build: [error] src/core/form/inputs/PortableText/Compositor.tsx:403:8 - TS2769: No overload matches this call.
sanity:build:   Overload 1 of 2, '(props: PolymorphicComponentProps<"web", Substitute<(Omit<RefAttributes<unknown>, "ref"> & RefAttributes<Component<RefAttributes<unknown>, any, any>>) | (Omit<...> & { ...; }), RefAttributes<...> & { ...; }>, void, void, {}, {}>): Element', gave the following error.

I traced it to this change:
https://npmdiff.dev/%40types%2Freact/18.3.3/18.3.5/react/index.d.ts/

What to review

Hopefully the ts-expect-error's are fine. It's expected that this will resolve itself in TS 5.6.

Testing

N/A

Notes for release

N/A

Copy link

vercel bot commented Sep 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 9, 2024 2:10pm
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 9, 2024 2:10pm
test-compiled-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 9, 2024 2:10pm
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 9, 2024 2:10pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 9, 2024 2:10pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Sep 9, 2024 2:10pm

Copy link
Contributor

github-actions bot commented Sep 9, 2024

No changes to documentation

Copy link
Contributor

github-actions bot commented Sep 9, 2024

Component Testing Report Updated Sep 9, 2024 2:13 PM (UTC)

✅ All Tests Passed -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 41s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 8s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 30s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 36s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 16s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 10s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 2m 33s 1 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 43s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 47s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 15s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 9s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 25s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 18s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 34s 12 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

@stipsan stipsan marked this pull request as ready for review September 9, 2024 14:33
@stipsan stipsan requested a review from a team as a code owner September 9, 2024 14:33
@stipsan stipsan requested review from ricokahler and removed request for a team September 9, 2024 14:33
@stipsan stipsan merged commit e2a30fe into next Sep 9, 2024
40 of 42 checks passed
@stipsan stipsan deleted the fix-tsc-errors branch September 9, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant