Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(router): reverting sticky params whilst issue with presentation exists #7489

Merged
merged 1 commit into from
Sep 10, 2024
Merged

chore(router): reverting sticky params whilst issue with presentation exists #7489

merged 1 commit into from
Sep 10, 2024

Conversation

jordanl17
Copy link
Member

Reverts #7429

@vercel Vercel
Copy link

vercel bot commented Sep 10, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 10, 2024 11:35am
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 10, 2024 11:35am
test-compiled-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 10, 2024 11:35am
test-next-studio 🔄 Building (Inspect) Visit Preview 💬 Add feedback Sep 10, 2024 11:35am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 10, 2024 11:35am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Sep 10, 2024 11:35am

@jordanl17 jordanl17 marked this pull request as ready for review September 10, 2024 10:42
@jordanl17 jordanl17 requested a review from a team as a code owner September 10, 2024 10:42
@jordanl17 jordanl17 requested review from cngonzalez and removed request for a team September 10, 2024 10:42
@github-actions GitHub Actions
Copy link
Contributor

No changes to documentation

@github-actions GitHub Actions
Copy link
Contributor

Component Testing Report Updated Sep 10, 2024 10:56 AM (UTC)

✅ All Tests Passed -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 42s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 8s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 30s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 36s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 17s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 10s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 3m 0s 0 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 44s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 45s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 14s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 8s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 26s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 18s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 34s 12 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

@RitaDias RitaDias added this pull request to the merge queue Sep 10, 2024
Merged via the queue into next with commit 5cb335b Sep 10, 2024
40 of 41 checks passed
@RitaDias RitaDias deleted the revert-7429-chore/corel-sticky-params branch September 10, 2024 11:53
juice49 added a commit that referenced this pull request Oct 4, 2024
@juice49
Revert "Revert "chore: support for sticky params in URL and intent ops (
9b15952 
#7429)" (#7489)"

This reverts commit 5cb335b.
juice49 added a commit that referenced this pull request Oct 7, 2024
@juice49
Revert "Revert "chore: support for sticky params in URL and intent ops (
177e88b 
#7429)" (#7489)"

This reverts commit 5cb335b.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobonamin pedrobonamin pedrobonamin approved these changes

@bjoerge bjoerge bjoerge approved these changes

@cngonzalez cngonzalez Awaiting requested review from cngonzalez cngonzalez was automatically assigned from sanity-io/sdk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jordanl17 @bjoerge @pedrobonamin @RitaDias