Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add efps github actions #7527

Merged
merged 4 commits into from
Sep 29, 2024

Conversation

binoy14
Copy link
Contributor

@binoy14 binoy14 commented Sep 19, 2024

Description

Adds a github action that runs EFPS test suite to compare PR performance to latest version of sanity.

What to review

It builds on the child branch and this branch is only responsible for the comment

Testing

N/A

Notes for release

N/A - internal

Copy link

vercel bot commented Sep 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 20, 2024 9:31pm
performance-studio ✅ Ready (Inspect) Visit Preview Sep 20, 2024 9:31pm
test-compiled-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 20, 2024 9:31pm
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 20, 2024 9:31pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 20, 2024 9:31pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Sep 20, 2024 9:31pm

Copy link
Contributor Author

binoy14 commented Sep 19, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @binoy14 and the rest of your teammates on Graphite Graphite

Copy link
Contributor

No changes to documentation

Copy link
Contributor

github-actions bot commented Sep 19, 2024

Component Testing Report Updated Sep 20, 2024 9:42 PM (UTC)

✅ All Tests Passed -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 43s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 8s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 31s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 36s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 18s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 10s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 3m 0s 0 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 44s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 42s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 16s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 9s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 26s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 18s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 36s 12 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

Copy link
Contributor

github-actions bot commented Sep 20, 2024

Benchmark Results

✅ Performance Benchmark Results — Status: **Passed**
Benchmark Passed? p50 eFPS (Δ%) p75 eFPS (Δ%) p90 eFPS (Δ%)
singleString 40.0 (+0.0%) 36.7 (-4.6%) 32.3 (+18.4%)
recipe (name) 30.3 (+3.0%) 27.8 (+0.7%) 23.9 (+7.2%)
recipe (description) 33.3 (+3.3%) 31.0 (+11.6%) 23.9 (+24.8%)
recipe (instructions) 90.9 (+22.7%) 65.6 (+17.5%) 55.6 (+5.6%)
article (title) 17.9 (+1.8%) 16.4 (+15.2%) 13.7 (+38.4%)
article (body) 33.7 (+20.1%) 31.5 (+24.7%) 22.5 (+57.5%)
article (string in object) 19.2 (+3.8%) 18.1 (+10.4%) 16.7 (+21.7%)
article (string in array) 14.4 (+2.2%) 13.7 (+5.5%) 11.4 (-0.2%)
synthetic (title) 14.5 (+2.9%) 14.0 (+5.3%) 11.7 (+8.1%)
synthetic (string in object) 14.6 (-2.9%) 13.8 (-0.3%) 11.3 (-9.0%)

eFPS — editor "Frames Per Second"

The number of renders ("frames") that is assumed to be possible within a second. Derived from input latency. Higher is better.

Copy link
Contributor

@juice49 juice49 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, based on my understanding!

@ricokahler ricokahler merged commit 1e48124 into test/compare-efps Sep 29, 2024
43 of 44 checks passed
@ricokahler ricokahler deleted the 09-19-chore_add_efps_github_actions branch September 29, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants