-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: preserve visited documents in documents-store
[WIP]
#7537
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
No changes to documentation |
Component Testing Report Updated Sep 25, 2024 9:16 AM (UTC) ✅ All Tests Passed -- expand for details
|
pedrobonamin
force-pushed
the
document-store-loader-next
branch
from
September 25, 2024 08:46
4997add
to
814d6d8
Compare
Canceled and replaced for #7552 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the ability to listen to the last N visited documents, allowing us to render them immediately when you open the form instead of having to wait for it to be fully loaded again.
It works for the following case:
corel
#7176store.previously.visited.documents.mov
What to review
It modifies the preview store to use mendoza patches, does this requires any other update?
Is something else from
corel
needed to be moved to this branch for the preview store to work?Testing
New tests added for the new observable.
Notes for release
Improvements to documents loading, preserving the last 5(confirm number) visited documents so users can see the document before the listener connection is established.