Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable source maps for package bundles #7540

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Conversation

rexxars
Copy link
Member

@rexxars rexxars commented Sep 24, 2024

Description

Enables source maps for the package bundles, and uploads them to the bucket as well. This also adds a check for the files found in the traversed directories - if they're not .mjs or .map, we will throw. I think this is actually a feature in disguise, as we don't necessarily want to start uploading other stuff that might be emitted/part of the folder structure.

I originally used the mime-types npm module, but felt the extra dependency was unnecessary for two different file types - so sticking with just a simple map for now.

What to review

  • Bundling outputs sourcemap and references it in the javascript file
  • Upload script logic appears correct

Testing

Ran this locally, but without uploading to a bucket.

Notes for release

None

@rexxars rexxars requested a review from a team as a code owner September 24, 2024 17:05
@rexxars rexxars requested review from ryanbonial and removed request for a team September 24, 2024 17:05
Copy link

vercel bot commented Sep 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 24, 2024 5:05pm
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 24, 2024 5:05pm
test-compiled-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 24, 2024 5:05pm
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 24, 2024 5:05pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 24, 2024 5:05pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Sep 24, 2024 5:05pm

Copy link
Contributor

No changes to documentation

Copy link
Contributor

Component Testing Report Updated Sep 24, 2024 5:19 PM (UTC)

✅ All Tests Passed -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 45s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 9s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 32s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 37s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 17s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 10s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 3m 0s 0 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 44s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 44s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 16s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 9s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 27s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 18s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 35s 12 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

Copy link
Contributor

@binoy14 binoy14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic makes sense, thanks!

Copy link
Member

@ryanbonial ryanbonial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rexxars rexxars merged commit 0396ec2 into next Sep 25, 2024
42 checks passed
@rexxars rexxars deleted the chore/module-source-maps branch September 25, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants