-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: enable source maps for package bundles #7540
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
No changes to documentation |
Component Testing Report Updated Sep 24, 2024 5:19 PM (UTC) ✅ All Tests Passed -- expand for details
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Logic makes sense, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Description
Enables source maps for the package bundles, and uploads them to the bucket as well. This also adds a check for the files found in the traversed directories - if they're not
.mjs
or.map
, we will throw. I think this is actually a feature in disguise, as we don't necessarily want to start uploading other stuff that might be emitted/part of the folder structure.I originally used the mime-types npm module, but felt the extra dependency was unnecessary for two different file types - so sticking with just a simple map for now.
What to review
Testing
Ran this locally, but without uploading to a bucket.
Notes for release
None