Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cli): remove reliance on node-machine-id #7545

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Conversation

bjoerge
Copy link
Member

@bjoerge bjoerge commented Sep 25, 2024

Description

This removes our usage of- and dependency on- the (seemingly abandoned) node-machine-id package

Closes: #7538
Fixes: #7542

What to review

Does the change make sense?

Testing

The existing test coverage on telemetry should be sufficient. I ran an additional manual check to verifiy that telemetry events are still submitted from the CLI, and I did not observe any errors.

Notes for release

  • Fixes an issue that could cause CLI to crash in certain environments.

Copy link

vercel bot commented Sep 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 25, 2024 11:13am
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 25, 2024 11:13am
test-compiled-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 25, 2024 11:13am
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 25, 2024 11:13am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 25, 2024 11:13am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Sep 25, 2024 11:13am

Copy link
Contributor

No changes to documentation

Copy link
Contributor

Component Testing Report Updated Sep 25, 2024 11:24 AM (UTC)

✅ All Tests Passed -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 43s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 9s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 30s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 37s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 17s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 11s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 2m 33s 1 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 44s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 41s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 17s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 8s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 27s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 18s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 34s 12 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

@bjoerge bjoerge requested a review from a team September 25, 2024 11:33
@bjoerge bjoerge marked this pull request as ready for review September 25, 2024 11:53
@bjoerge bjoerge requested a review from a team as a code owner September 25, 2024 11:53
@bjoerge bjoerge requested review from ricokahler and removed request for a team September 25, 2024 11:53
Copy link
Contributor

@svirs svirs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+0 −7 👍

@bjoerge bjoerge added this pull request to the merge queue Sep 25, 2024
Merged via the queue into next with commit de9c29b Sep 25, 2024
50 checks passed
@bjoerge bjoerge deleted the remove-node-machine-id branch September 25, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dev command crushing in Sanity + Astro Turborepo
3 participants