-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Request Edit Access flow #7546
Open
drewlyton
wants to merge
30
commits into
next
Choose a base branch
from
feat/gro-2558
base: next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+381
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
No changes to documentation |
Component Testing Report Updated Oct 1, 2024 7:46 AM (UTC) ✅ All Tests Passed -- expand for details
|
pedrobonamin
previously approved these changes
Sep 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @drewlyton ! Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a new "Request Edit Access" feature into the studio that allows users to make a request for a role change from Viewer to Editor/Administrator (depending on the project's available roles).
What to review
There are 2 main areas of the Studio that are touched/introduced with this PR:
PermissionCheckBanner
and..RequestPermissionDialog
PermissionCheckBanner
This banner has been updated to show an "Ask to edit" button in the action area if the user is ONLY a Viewer.
RequestPermissionDialog
This is where most of the code is introduced. This new Dialog works very similarly to the
RequestAccessScreen
with some changes to the request logic, error handling, and POST params.Testing
This PR introduces no new automated tests.
Notes for release
This new "Request Edit Access" feature will be available to all users - with administrators being able to Approve/Deny requests in the Requests tab in Manage.