chore(form): remove imports from shouldArrayDialogOpen #7550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
|
No changes to documentation |
|
Component Testing Report Updated Sep 27, 2024 6:26 AM (UTC) ✅ All Tests Passed -- expand for details
|
RitaDias
requested review from
juice49,
rexxars and
a team
and removed request for
a team
rexxars
requested changes
Sep 26, 2024
There was a problem hiding this comment.
Also , I simply commented the code since I am unsure if in the future when we return to this we would want to have the code.
Let's remove it for now. You don't need to do a deep clean up for now, but just removing the commented code would be good. We can always refer back to/revert this PR/commit to bring it back.
RitaDias
force-pushed
the
remove-should-array-dialog
branch
from
d5e3c8e
to
d267d16
Compare
RitaDias
force-pushed
the
remove-should-array-dialog
branch
from
d267d16
to
2f8f10b
Compare
Fair enough, done :) |
rexxars
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There's been some issues when upgrading vite 5 around the exporting of shouldArrayDialogOpen.
This was part of the Modal Madness work and while removing it might be considered a breaking change since the whole beta feature has been taken down it should be fine.
Also , I simply commented the code since I am unsure if in the future when we return to this we would want to have the code. If it's preferrable to simply delete it then I'll likely need to actively delete more components and do a more general clean up (which might be what we want but I'll leave that up to the reviewers)
What to review
Taking a stance on the description written above should be enough
Notes for release
N/A