fix(preview): allow null as valid cache/memo value for preview fields
#7551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
|
No changes to documentation |
pedrobonamin
previously approved these changes
Sep 26, 2024
|
Component Testing Report Updated Sep 26, 2024 11:34 AM (UTC) ✅ All Tests Passed -- expand for details
|
bjoerge
force-pushed
the
fix-preview-value-memo
branch
from
44f8fef
to
4fc46c4
Compare
bjoerge
changed the title
null as valid cache/memo value for preview fieldsnull as valid cache/memo value for preview fields
bjoerge
requested review from
cngonzalez and
pedrobonamin
and removed request for
a team
pedrobonamin
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When previewing a document field, we keep a memo of the latest value so that when resubscribing to the same document later starts by emitting the latest known value (before we fetch from the server).
However, there was a flaw in the current implementation causing unneccessary loading states to appear in the studio:
In short: We assumed the memo being
nullmeant that it hadn't been set, but in many cases it’s being explicitly set tonullbecause we getnullback from fetching the fields from the server.This PR fixes the issue by instead treating
undefinedas "memo not being set".What to review
See code changes + added tests
Testing
Added a unit test covering this particular case.
Notes for release