feat(sanity): add config for onUncaughtError #7553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
RitaDias
commented
Sep 27, 2024
RitaDias
commented
Sep 27, 2024
packages/sanity/src/core/form/inputs/files/ImageInput/ImageInput.tsx
Outdated
Show resolved
Hide resolved
|
No changes to documentation |
|
Component Testing Report Updated Oct 7, 2024 9:23 AM (UTC) ✅ All Tests Passed -- expand for details
|
RitaDias
commented
Sep 30, 2024
| @@ -30,15 +33,30 @@ export function WorkspaceRouterProvider({ | |||
| const history = useRouterHistory() | |||
| const router = useMemo(() => createRouter({basePath, tools}), [basePath, tools]) | |||
| const [state, onNavigate] = useRouterFromWorkspaceHistory(history, router, tools) | |||
| const {onStudioError} = useSource() | |||
There was a problem hiding this comment.
catching the ErrorBoundary from StudioErrorBoundary since it has the context it needs here
There was a problem hiding this comment.
If there is a better place for this than this component I'd love to hear it, areas "above" didn't have the SourceContext needed (as far as I was able to tell)
RitaDias
force-pushed
the
edx-1601
branch
3 times, most recently
from
9638d5d
to
490e32e
Compare
RitaDias
commented
Sep 30, 2024
packages/sanity/src/structure/components/structureTool/StructureTitle.tsx
Outdated
Show resolved
Hide resolved
bjoerge
reviewed
Oct 7, 2024
packages/sanity/src/core/studio/workspaceLoader/WorkspaceRouterProvider.tsx
Outdated
Show resolved
Hide resolved
RitaDias
changed the title
bjoerge
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds ability to callback when an error happens and allows developers to add custom error telemetry (for example)
I will drop the throw errors before merging, those are for testing purposes
What to review
useSource, the current place where it exists seems to be the better option. If you all have any other suggestions I'd love to hear it!Testing
Automated tests are in place.
You can also manually trigger it by adding
throw new error("oh no new error)within theimageInputor thestudioComponentsand then going to thecustom-components/structureworkspace and seeing the console logs workNotes for release
Adds ability to callback when an error happens and allows developers to use errors thrown by the studio