fix(core): emit local settings value immediately upon subscription #7560
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes an oversight in #7554. This reads and emits the current local settings value upon subscription (syncronously), which was the intention with #7554, but I forgot to actually read it initially 🙈
What to review
I also removed the (currently disabled) sync between tabs. We can revisit this in the future, but if we want this it should probably be on a "per-setting" basis (for future reference, I've made a quick POC for that in the
keyval-support-cross-tab-sync
-branch)Notes for release
n/a internal