-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): fixes an issue with pasting in conditional readonly field #7564
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
No changes to documentation |
Component Testing Report Updated Sep 30, 2024 7:29 PM (UTC) ✅ All Tests Passed -- expand for details
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, and kudos for the thorough tests 👏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, great work!
Description
Fixes an issue where pasting in a conditional readOnly field would not actually resolve the value of the property and always return true for a function. This PR fixes it so that the actual resolved value is used
What to review
Error Case
Actual: Cannot paste even if the field is not read only
Fixed Case
Actual: Can paste if the field is not read only also cannot paste if the field is not read only
Testing
Unit tests added for the function
Notes for release
readOnly
field would not used the returned value