Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): upgrade moment, drop @types module #7565

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Conversation

rexxars
Copy link
Member

@rexxars rexxars commented Sep 30, 2024

Description

We are implicitly already depending on the new version (through the version range), so this is mostly to get rid of a deprecation notice on the types module.

What to review

Stuff still works. The only place we still use this is in a deprecated old date format that we can hopefully get rid of in Sanity v4.

Testing

No new tests needed.

Notes for release

None.

@rexxars rexxars requested a review from a team as a code owner September 30, 2024 23:32
@rexxars rexxars requested review from ricokahler and removed request for a team September 30, 2024 23:32
Copy link

vercel bot commented Sep 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 30, 2024 11:38pm
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 30, 2024 11:38pm
test-compiled-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 30, 2024 11:38pm
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 30, 2024 11:38pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 30, 2024 11:38pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Sep 30, 2024 11:38pm

Copy link
Contributor

No changes to documentation

Copy link
Contributor

Component Testing Report Updated Sep 30, 2024 11:45 PM (UTC)

✅ All Tests Passed -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 46s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 8s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 31s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 37s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 18s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 10s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 3m 0s 0 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 45s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 43s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 16s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 9s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 25s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 18s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 35s 12 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

@rexxars rexxars added this pull request to the merge queue Oct 1, 2024
Merged via the queue into next with commit be73a2a Oct 1, 2024
50 checks passed
@rexxars rexxars deleted the fix/moment-upgrade branch October 1, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants