Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(structure): remove perspective from paneRouter #7700

Merged
merged 2 commits into from
Oct 30, 2024

Conversation

pedrobonamin
Copy link
Contributor

Description

Perspective is only a global concept, initially we allowed changing the perspective in each pane, but that is not supported anymore.
Removing this simplifies things for consumers and allows presentation to render the releases form in the correct way.

What to review

Testing

Notes for release

@pedrobonamin pedrobonamin requested review from a team as code owners October 30, 2024 09:46
@pedrobonamin pedrobonamin requested review from rexxars and removed request for a team October 30, 2024 09:46
Copy link

vercel bot commented Oct 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2024 10:38am
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2024 10:38am
test-compiled-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2024 10:38am
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2024 10:38am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2024 10:38am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Oct 30, 2024 10:38am

Copy link
Contributor

No changes to documentation

Copy link
Contributor

github-actions bot commented Oct 30, 2024

Component Testing Report Updated Oct 30, 2024 10:37 AM (UTC)

✅ All Tests Passed -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 1m 10s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 14s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 42s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 53s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 29s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 16s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 3m 0s 0 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 1m 15s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 2m 47s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 54s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 14s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 42s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 29s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 57s 12 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

Copy link
Contributor

github-actions bot commented Oct 30, 2024

⚡️ Editor Performance Report

Updated Wed, 30 Oct 2024 10:50:36 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 15.3 efps (66ms) 11.7 efps (86ms) +20ms (+30.5%) 🔴
article (body) 53.5 efps (19ms) 59.7 efps (17ms) -2ms (-10.4%)
article (string inside object) 16.4 efps (61ms) 12.3 efps (81ms) +20ms (+32.8%) 🔴
article (string inside array) 13.6 efps (74ms) 10.4 efps (96ms) +23ms (+30.6%) 🔴
recipe (name) 27.4 efps (37ms) 20.0 efps (50ms) +14ms (+37.0%) 🔴
recipe (description) 30.3 efps (33ms) 21.3 efps (47ms) +14ms (+42.4%) 🔴
recipe (instructions) 99.9+ efps (6ms) 99.9+ efps (6ms) -0ms (-/-%)
synthetic (title) 13.9 efps (72ms) 5.6 efps (180ms) +108ms (+150.0%) 🔴
synthetic (string inside object) 14.2 efps (71ms) 5.9 efps (169ms) +99ms (+139.7%) 🔴

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 66ms 76ms 86ms 240ms 689ms 13.6s
article (body) 19ms 21ms 30ms 216ms 236ms 6.2s
article (string inside object) 61ms 64ms 73ms 341ms 647ms 9.3s
article (string inside array) 74ms 78ms 92ms 309ms 1310ms 10.1s
recipe (name) 37ms 40ms 50ms 79ms 0ms 10.1s
recipe (description) 33ms 35ms 38ms 148ms 0ms 6.4s
recipe (instructions) 6ms 8ms 9ms 10ms 0ms 3.2s
synthetic (title) 72ms 78ms 85ms 156ms 1286ms 16.4s
synthetic (string inside object) 71ms 74ms 82ms 447ms 1769ms 10.8s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 86ms 98ms 129ms 497ms 4206ms 19.0s
article (body) 17ms 22ms 55ms 299ms 832ms 7.6s
article (string inside object) 81ms 87ms 279ms 555ms 4281ms 13.8s
article (string inside array) 96ms 108ms 289ms 468ms 5176ms 16.0s
recipe (name) 50ms 58ms 87ms 238ms 2534ms 13.5s
recipe (description) 47ms 54ms 82ms 195ms 2355ms 10.6s
recipe (instructions) 6ms 8ms 10ms 14ms 0ms 4.1s
synthetic (title) 180ms 196ms 477ms 954ms 13015ms 30.6s
synthetic (string inside object) 169ms 185ms 488ms 722ms 11885ms 23.6s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant