Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sanity): update inputs #7701

Closed
wants to merge 8 commits into from
Closed

feat(sanity): update inputs #7701

wants to merge 8 commits into from

Conversation

RitaDias
Copy link
Contributor

Description

What to review

Testing

Notes for release

Copy link

vercel bot commented Oct 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2024 4:23pm
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2024 4:23pm
test-compiled-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2024 4:23pm
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2024 4:23pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2024 4:23pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Oct 30, 2024 4:23pm

@RitaDias RitaDias changed the title Corel 175 feat(sanity): update inputs Oct 30, 2024
Copy link
Contributor

No changes to documentation

Copy link
Contributor

github-actions bot commented Oct 30, 2024

Component Testing Report Updated Oct 30, 2024 4:18 PM (UTC)

✅ All Tests Passed -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 1m 9s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 14s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 42s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 54s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 29s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 16s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 2m 34s 1 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 1m 13s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 2m 54s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 51s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 15s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 43s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 30s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 59s 12 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

Copy link
Contributor

github-actions bot commented Oct 30, 2024

⚡️ Editor Performance Report

Updated Wed, 30 Oct 2024 16:31:31 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 16.1 efps (62ms) 12.4 efps (81ms) +19ms (+29.8%) 🔴
article (body) 53.3 efps (19ms) 56.8 efps (18ms) -1ms (-6.1%)
article (string inside object) 16.9 efps (59ms) 13.2 efps (76ms) +17ms (+28.8%) 🔴
article (string inside array) 14.5 efps (69ms) 10.5 efps (95ms) +26ms (+37.7%) 🔴
recipe (name) 27.0 efps (37ms) 19.0 efps (53ms) +16ms (+41.9%) 🔴
recipe (description) 30.3 efps (33ms) 20.6 efps (49ms) +16ms (+47.0%) 🔴
recipe (instructions) 99.9+ efps (6ms) 99.9+ efps (7ms) +1ms (-/-%)
synthetic (title) 13.9 efps (72ms) 5.7 efps (174ms) +102ms (+141.7%) 🔴
synthetic (string inside object) 13.7 efps (73ms) 5.9 efps (169ms) +96ms (+130.8%) 🔴

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 62ms 67ms 77ms 265ms 550ms 14.1s
article (body) 19ms 22ms 44ms 231ms 322ms 6.2s
article (string inside object) 59ms 63ms 67ms 229ms 596ms 9.2s
article (string inside array) 69ms 73ms 85ms 223ms 1062ms 9.7s
recipe (name) 37ms 45ms 56ms 128ms 21ms 10.4s
recipe (description) 33ms 37ms 60ms 174ms 34ms 6.6s
recipe (instructions) 6ms 8ms 10ms 29ms 5ms 3.4s
synthetic (title) 72ms 74ms 82ms 312ms 1549ms 15.6s
synthetic (string inside object) 73ms 77ms 91ms 362ms 2005ms 10.5s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 81ms 93ms 151ms 450ms 3796ms 18.1s
article (body) 18ms 20ms 31ms 172ms 466ms 7.2s
article (string inside object) 76ms 81ms 88ms 347ms 2878ms 12.0s
article (string inside array) 95ms 102ms 280ms 562ms 5236ms 15.7s
recipe (name) 53ms 60ms 90ms 223ms 2517ms 13.9s
recipe (description) 49ms 58ms 83ms 239ms 2396ms 10.7s
recipe (instructions) 7ms 9ms 11ms 185ms 130ms 4.4s
synthetic (title) 174ms 187ms 429ms 1032ms 12230ms 29.3s
synthetic (string inside object) 169ms 185ms 266ms 807ms 11747ms 24.4s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant