Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: telemetry definition files are owned by @data-eng #7703

Merged
merged 1 commit into from
Oct 31, 2024
Merged

chore: telemetry definition files are owned by @data-eng #7703

merged 1 commit into from
Oct 31, 2024

Conversation

svirs
Copy link
Contributor

@svirs svirs commented Oct 30, 2024

No notes for release, merely updating CODEOWNERS to @sanity-io/data-eng from @sanity-io/growth for who gets pinged for these files

@svirs svirs requested a review from a team as a code owner October 30, 2024 16:16
@svirs svirs requested review from cngonzalez and removed request for a team October 30, 2024 16:16
@vercel Vercel
Copy link

vercel bot commented Oct 30, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2024 9:39pm
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2024 9:39pm
test-compiled-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2024 9:39pm
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2024 9:39pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2024 9:39pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Oct 30, 2024 9:39pm

@github-actions GitHub Actions
Copy link
Contributor

No changes to documentation

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 30, 2024 •
edited
Loading

Component Testing Report Updated Oct 30, 2024 9:40 PM (UTC)

✅ All Tests Passed -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 46s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 9s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 32s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 39s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 18s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 11s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 3m 0s 0 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 46s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 43s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 17s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 9s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 27s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 18s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 36s 12 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 30, 2024 •
edited
Loading

⚡️ Editor Performance Report

Updated Wed, 30 Oct 2024 21:45:22 GMT

Benchmark reference
latency of sanity@latest		 experiment
latency of this branch		 Δ (%)
latency difference
article (title) 16.4 efps (61ms) 16.4 efps (61ms) +0ms (-/-%) ✅
article (body) 63.1 efps (16ms) 59.5 efps (17ms) +1ms (+6.0%) ✅
article (string inside object) 17.5 efps (57ms) 17.5 efps (57ms) +0ms (-/-%) ✅
article (string inside array) 14.3 efps (70ms) 14.7 efps (68ms) -2ms (-2.9%) ✅
recipe (name) 27.4 efps (37ms) 29.4 efps (34ms) -3ms (-6.8%) ✅
recipe (description) 31.3 efps (32ms) 32.8 efps (31ms) -2ms (-4.7%) ✅
recipe (instructions) 99.9+ efps (6ms) 99.9+ efps (6ms) +0ms (-/-%) ✅
synthetic (title) 13.5 efps (74ms) 14.1 efps (71ms) -3ms (-4.1%) ✅
synthetic (string inside object) 13.9 efps (72ms) 14.3 efps (70ms) -2ms (-2.8%) ✅

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 61ms 70ms 123ms 324ms 703ms 15.1s
article (body) 16ms 19ms 22ms 192ms 309ms 6.0s
article (string inside object) 57ms 61ms 65ms 256ms 578ms 8.8s
article (string inside array) 70ms 72ms 78ms 138ms 1137ms 9.7s
recipe (name) 37ms 39ms 56ms 79ms 10ms 9.2s
recipe (description) 32ms 36ms 53ms 169ms 3ms 6.4s
recipe (instructions) 6ms 8ms 9ms 10ms 0ms 3.2s
synthetic (title) 74ms 85ms 110ms 349ms 2037ms 16.3s
synthetic (string inside object) 72ms 83ms 112ms 387ms 2133ms 11.2s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 61ms 71ms 82ms 160ms 439ms 13.9s
article (body) 17ms 20ms 49ms 195ms 308ms 5.9s
article (string inside object) 57ms 59ms 70ms 203ms 451ms 8.8s
article (string inside array) 68ms 71ms 86ms 321ms 1159ms 9.6s
recipe (name) 34ms 38ms 59ms 77ms 25ms 8.8s
recipe (description) 31ms 32ms 49ms 155ms 6ms 6.2s
recipe (instructions) 6ms 8ms 9ms 10ms 0ms 3.3s
synthetic (title) 71ms 76ms 86ms 404ms 1731ms 15.3s
synthetic (string inside object) 70ms 79ms 150ms 506ms 2295ms 11.0s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

@svirs svirs added this pull request to the merge queue Oct 31, 2024
Merged via the queue into next with commit 7ed0f9c Oct 31, 2024
65 of 67 checks passed
@svirs svirs deleted the gro-2773 branch October 31, 2024 14:08
bjoerge added a commit that referenced this pull request Nov 1, 2024
@bjoerge
Merge branch 'next' into corel
ea93fea 
* next: (25 commits)
  fix(deps): update dependency @sanity/ui to ^2.8.16 (#7723)
  fix(deps): update dependency @sanity/ui to ^2.8.16 (#7722)
  chore(lockfile): update dependency @sanity/asset-utils to v2.0.7 (#7721)
  fix(deps): update dependency @sanity/ui to ^2.8.15 (#7717)
  fix(deps): update dependency @sanity/ui to ^2.8.15 (#7718)
  fix(deps): Update babel monorepo (#7719)
  chore(deps): update typescript-tooling (#7681)
  chore(deps): bump react-compiler linter (#7715)
  fix(deps): Update dev-non-major (#7708)
  fix(deps): update dependency react-rx to ^4.1.0 (#7714)
  fix(deps): update dependency @portabletext/editor to ^1.2.0 (#7709)
  chore(deps): update dependency lerna to ^8.1.9 (#7711)
  fix(deps): update dependency @sanity/ui to ^2.8.14 (#7713)
  chore: telemetry definition files are owned by @data-eng (#7703)
  fix(deps): update dependency react-rx to ^4.0.1 (#7712)
  fix(deps): Update dev-non-major (#7693)
  chore(deps): update dependency @vitejs/plugin-react to ^4.3.3 (#7688)
  fix(deps): update dependency @sanity/ui to ^2.8.13 (#7694)
  fix(deps): update dependency @portabletext/editor to ^1.1.11 (#7667)
  feat(cli): prepare nextjs starter template for live mode (#7633)
  ...
jordanl17 pushed a commit that referenced this pull request Nov 5, 2024
@svirs @jordanl17
chore: telemetry definition files are owned by @data-eng (#7703)
65ecdaa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cngonzalez cngonzalez cngonzalez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@svirs @cngonzalez