Replaced stream with for loop for slightly better performance

santanusinha · Nov 3, 2023 · 231be41 · 231be41
1 parent 65cdb02
commit 231be41
Showing 1 changed file with 12 additions and 6 deletions.
diff --git a/hope-core/src/main/java/io/appform/hope/core/visitors/Evaluator.java b/hope-core/src/main/java/io/appform/hope/core/visitors/Evaluator.java
@@ -72,18 +72,24 @@ public List<Boolean> evaluate(
             final List<Evaluatable> evaluatables,
             final JsonNode node) {
         val logicEvaluator = new LogicEvaluator(new EvaluationContext(parseContext.parse(node), node, this));
-        return evaluatables.stream()
-                .map(evaluatable -> evaluatable.accept(logicEvaluator))
-                .collect(Collectors.toList());
+        List<Boolean> list = new ArrayList<>();
+        for (Evaluatable evaluatable : evaluatables) {
+            list.add(evaluatable.accept(logicEvaluator));
+        }
+        return list;
     }
 
     public OptionalInt evaluateFirst(
             final List<Evaluatable> rules,
             final JsonNode node) {
         val logicEvaluator = new LogicEvaluator(new EvaluationContext(parseContext.parse(node), node, this));
-        return IntStream.range(0, rules.size())
-                .filter(index -> rules.get(index).accept(logicEvaluator))
-                .findFirst();
+        int bound = rules.size();
+        for (int index = 0; index < bound; index++) {
+            if (rules.get(index).accept(logicEvaluator)) {
+                return OptionalInt.of(index);
+            }
+        }
+        return OptionalInt.empty();
     }
 
     @Data