Add sentiment bal vc v2 metrics #4010
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volynvlad
force-pushed
the
add-sentiment-bal-vc-v2-metrics
branch
2 times, most recently
from
ed7d804 to
07fc31d
Compare
volynvlad
force-pushed
the
add-sentiment-bal-vc-v2-metrics
branch
from
07fc31d to
ae5c5e8
Compare
volynvlad
force-pushed
the
add-sentiment-bal-vc-v2-metrics
branch
2 times, most recently
from
f501093 to
14a39ef
Compare
volynvlad
force-pushed
the
add-sentiment-bal-vc-v2-metrics
branch
from
8517692 to
b0d0e97
Compare
IvanIvanoff
force-pushed
the
add-sentiment-bal-vc-v2-metrics
branch
2 times, most recently
from
59383d1 to
b21624e
Compare
volynvlad
force-pushed
the
add-sentiment-bal-vc-v2-metrics
branch
from
b21624e to
50bb236
Compare
apozdeyev
reviewed
Dec 8, 2023
| @@ -1434,6 +1434,56 @@ defmodule Sanbase.Billing.MetricAccessLevelTest do | |||
| "total_trustlines_count", | |||
| "dex_volume_in_xrp_5m", | |||
| "dex_volume_in_usd_5m", | |||
| # sentiment balance v2 metrics | |||
There was a problem hiding this comment.
seems forgot to add sentiment_volume_consumed_5m
IvanIvanoff
reviewed
May 15, 2024
| }, | ||
| { | ||
| "human_readable_name": "Sentiment Volume Consumed Daily 4chan v2", | ||
| "name": "weighted_sentiment_4chan_v2_1d", |
There was a problem hiding this comment.
it would be better to always have the _v2 as a prefix, so we'll have:
sentiment_weighted_4chan_1d(old)sentiment_weighted_4chan_1d_v2
so, if you do a text search forsentiment_weighted_4chan_1dyou'll be able to find both the old and the new metric, i.e. not infixing the version between some of the other arguments.
|
Close and open new PR #4260 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add sentiment balance and sentiment volume consumed v2 metrics (calculated with CH instead of ES + python)
Ticket
Checklist: