Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert the trending words query to the old one + FINAL #4022

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

IvanIvanoff
Copy link
Member

In the now reverted query there is a check like t = dt and t = last_dt_in_group. This is an issue because t is being computed as the beginning of the interval, so a check where t=last_dt_in_group would never yield the required result -- the data with last dt

Changes

Ticket

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have tried to find clearer solution before commenting hard-to-understand parts of code
  • I have added tests that prove my fix is effective or that my feature works

In the now reverted query there is a check like t = dt and t =
last_dt_in_group. This is an issue because t is being computed as the
beginning of the interval, so a check where t=last_dt_in_group would
never yield the required result -- the data with last dt
@IvanIvanoff IvanIvanoff merged commit 4ffa75f into master Dec 7, 2023
@delete-merged-branch delete-merged-branch bot deleted the revert-trending-words-query branch December 7, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants