Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix storing/getting of queries execution stats #4028

Merged
merged 1 commit into from
Dec 11, 2023
Merged

Fix storing/getting of queries execution stats #4028

merged 1 commit into from
Dec 11, 2023

Conversation

IvanIvanoff
Copy link
Member

@IvanIvanoff IvanIvanoff commented Dec 11, 2023 •
edited
Loading

Changes

  • Fix issue with storing of Clickhouse query executions -- Float.round was called on an integer.
  • Move the query from the dashboard to the queries resolver and use the Queries implementation.

Ticket

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have tried to find clearer solution before commenting hard-to-understand parts of code
  • I have added tests that prove my fix is effective or that my feature works

@IvanIvanoff IvanIvanoff force-pushed the fix-get-executions-stats branch from 2d061fe to 346789c Compare December 11, 2023 12:43
@IvanIvanoff IvanIvanoff merged commit e4ab7cf into master Dec 11, 2023
1 check passed
@delete-merged-branch delete-merged-branch bot deleted the fix-get-executions-stats branch December 11, 2023 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@IvanIvanoff