[RUIN-269] Reduce effects of question loading lagging and add loading spinner on question form #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KristinAoki
requested changes
Mar 29, 2022
| @@ -14,6 +14,7 @@ const MultiButtonSelectorQuickSurvey = (props) => { | |||
| // obtained as inputs to component made in QuickSurvey | |||
| const {data, quickSurveyReducer, submitFunction, updateResponse, dependencyID} = props; | |||
| let currId = data.humanReadableId | |||
| console.log(data); | |||
| @@ -10,7 +10,7 @@ import QuestionSection from '../QuestionSection'; | |||
|
|
|||
| const NumberButtonSelectorQuickSurvey = (props) => { | |||
| const [selection, setSelection] = React.useState('') | |||
| // console.log(selection) | |||
| console.log('numerbuttonselectorquicksurvey selection:', selection) | |||
| @@ -122,7 +122,7 @@ const DropDownMultiSelect = (props) => { | |||
| setSelectedOptions([]); | |||
| return; | |||
| } | |||
| // console.log(selectedOptions) | |||
| console.log('dropdownmultiselect selectedoptions:', selectedOptions) | |||
src/screens/welcome/Welcome.js
Outdated
| } else { | ||
| this.setState({ autoSavedSession: false, filePickerDialogBoxVisible: false }); | ||
| console.log('No unfinished report!'); | ||
| // console.log('No unfinished report!'); |
src/screens/welcome/Welcome.js
Outdated
| @@ -58,10 +58,10 @@ class Welcome extends Component { | |||
| checkAutoSavedSession(){ | |||
| if (this.stateManager.filePaths != null) { | |||
| this.setState({autoSavedSession : true, filePickerDialogBoxVisible: true}); | |||
| console.log('Detect unfinished reports!'); | |||
| // console.log('Detect unfinished reports!'); | |||
|
Do you know what the trace.html file is for? |
added 6 commits
April 2, 2022 16:09
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, the questions on the question form took an extremely long time to load, which was frustrating. This change attempts to reduce some of this lagging by reducing the repetitive computation needed to load questions. However, the change in lag was not significant after this, so additionally, I have added a loading spinner to the question form to visually communicate to the user that the questions are loading. While still frustrating, the loading spinner makes the wait less confusing. Regardless, in the future, we should try to address the underlying lag issue.
Testing