Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update _set_axis(): fix layout property deletion bug #251

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rightx2
Copy link

@rightx2 rightx2 commented Aug 11, 2020

fig['layout'] in _set_axis(), which is an object of plotly.graph_objs.Layout should not be used with del because the class and its all parent classes do not implement __delitem__. So, it will raise AttributeError: __delitem__ instead of KeyError.

So, I fixed it by accessing _props directly. But it might not look good because the underscore + property is usually called inside of an instance method, not the outside of the object. Any comments or fixes will be welcomed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant