Update _set_axis(): fix layout property deletion bug #251
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fig['layout']
in_set_axis()
, which is an object ofplotly.graph_objs.Layout
should not be used withdel
because the class and its all parent classes do not implement__delitem__
. So, it will raiseAttributeError: __delitem__
instead ofKeyError
.So, I fixed it by accessing
_props
directly. But it might not look good because theunderscore + property
is usually called inside of an instance method, not the outside of the object. Any comments or fixes will be welcomed!