Skip to content

Commit

Permalink
fix typos to make codespell happy
Browse files Browse the repository at this point in the history
  • Loading branch information
alexxa committed Jan 3, 2024
1 parent f0a6a41 commit 7cdb7b9
Show file tree
Hide file tree
Showing 44 changed files with 62 additions and 63 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ The logic has been separated to support a flexible execution of the different st

## Execution examples

There are various methods to execute the Ansible Collection, dependant on the use case. For more information, see [Execution examples with code samples](./docs/getting_started) and the summary below:
There are various methods to execute the Ansible Collection, dependent on the use case. For more information, see [Execution examples with code samples](./docs/getting_started) and the summary below:

| Execution Scenario | Use Case | Target |
| ---- | ---- | ---- |
Expand Down
2 changes: 1 addition & 1 deletion docs/developer_notes/sap_swmp_dev.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

## Errors with missing signature files for installation media

After SWPM 1.0 SP22 and SAP SWPM 2.0 SP00, all SAP Software installation media requires a seperate signature file (SIGNATURE.SMF). The signature file is missing in older installation media.
After SWPM 1.0 SP22 and SAP SWPM 2.0 SP00, all SAP Software installation media requires a separate signature file (SIGNATURE.SMF). The signature file is missing in older installation media.

For example, IDES for SAP ECC 6.0 EhP8. See the following error message and SAP Note 2622019 - "EXPORT_1 is not signed" error during IDES installation.
```shell
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ NW_DDIC_Password.needDDICPasswords = false
# Master password
NW_GetMasterPassword.masterPwd = NewPass$321

# Human readable form of the default login language to be preselected in SAPGUI. This Parameter is potentialy prompted in addition in the screen that also asks for the <SAPSID>. It is only prompted in systems that have an ABAP stack. It is prompted for installation but not for system copy. It is asked in those installations, that perform the ABAP load. That could be the database load installation in case of a distributed system szenario, or in case of a standard system installation with all instances on one host. This Parameter is saved in the 'DEFAULT' profile. It is has no influence on language settings in a Java stack. Valid names are stored in a table of subcomponent 'NW_languagesInLoadChecks'. The available languages must be declaired in the 'LANGUAGES_IN_LOAD' parameter of the 'product.xml' file . In this file, the one-character representation of the languages is used. Check the same table in subcomponent 'NW_languagesInLoadChecks'.
# Human readable form of the default login language to be preselected in SAPGUI. This Parameter is potentially prompted in addition in the screen that also asks for the <SAPSID>. It is only prompted in systems that have an ABAP stack. It is prompted for installation but not for system copy. It is asked in those installations, that perform the ABAP load. That could be the database load installation in case of a distributed system scenario, or in case of a standard system installation with all instances on one host. This Parameter is saved in the 'DEFAULT' profile. It is has no influence on language settings in a Java stack. Valid names are stored in a table of subcomponent 'NW_languagesInLoadChecks'. The available languages must be declaired in the 'LANGUAGES_IN_LOAD' parameter of the 'product.xml' file . In this file, the one-character representation of the languages is used. Check the same table in subcomponent 'NW_languagesInLoadChecks'.
# NW_GetSidNoProfiles.SAP_GUI_DEFAULT_LANGUAGE =

# Windows only: The drive to use
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
## DISPLAY env var, not required for when Silent installation (-silent operator for RUNINSTALLER)
## DB_SID env var / -db_sid option. If unset then error "[FATAL] [INS-35072] The SID cannot be left blank."
## ORACLE_BASE env var / -oracle_base option, Oracle Base /oracle. If unset then error "[FATAL] [INS-32013] The Oracle base location is empty." If option -oracle_base unused, may cause "Using new ORACLE_BASE=/oracle/<DB_SID> instead of ORACLE_BASE=/oracle" which will cause directory lookup failure and error "[FATAL] [INS-35072] The SID cannot be left blank."
## ORACLE_HOME env var / -install_home opiton, Oracle Home - Installation
## ORACLE_HOME env var / -install_home option, Oracle Home - Installation
## ORACLE_HOME_NAME env var / -oracle_home_name option, Oracle Home - Installation name in Oracle Inventory. Uses a naming convention - see https://docs.oracle.com/cd/E26854_01/em.121/e37799/ch2_manage_oh.htm#OUICG137
## OHRDBMS env var / -runtime_home, Oracle Home - Runtime
## ORA_GOLD_IMAGE_FILE_L env var / -oracle_stage option, Oracle home image file path. If unset then error "(ERROR ) - Error during unzip occurred" where no file is given to extract
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -546,7 +546,7 @@ initParams=
# Datatype : Boolean
# Description : Specifies whether or not to add the Sample Schemas to your database
# Valid values : TRUE \ FALSE
# Default value : FASLE
# Default value : FALSE
# Mandatory : No
#-----------------------------------------------------------------------------
sampleSchema=
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ DEINSTALL_LIST={"oracle.server","19.0.0.0.0"}
#-------------------------------------------------------------------------------
#Name : SHOW_DEINSTALL_CONFIRMATION
#Datatype : Boolean
#Description: Set to true if deinstall confimation is needed during a deinstall session.
#Description: Set to true if deinstall confirmation is needed during a deinstall session.
#Example: SHOW_DEINSTALL_CONFIRMATION = true
#-------------------------------------------------------------------------------
SHOW_DEINSTALL_CONFIRMATION=true
Expand Down
2 changes: 1 addition & 1 deletion roles/sap_general_preconfigure/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,7 @@ List of SAP directories to be created.<br>
- _Type:_ `bool`
- _Default:_ `true`

Set to `false` if you do not want to modify the SELinux labels for the SAP directores set<br>
Set to `false` if you do not want to modify the SELinux labels for the SAP directories set<br>
in variable `sap_general_preconfigure_sap_directories`.<br>

### sap_general_preconfigure_size_of_tmpfs_gb
Expand Down
2 changes: 1 addition & 1 deletion roles/sap_general_preconfigure/defaults/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ sap_general_preconfigure_sap_directories:
# List of SAP directories to be created.

sap_general_preconfigure_modify_selinux_labels: true
# Set to `false` if you do not want to modify the SELinux labels for the SAP directores set
# Set to `false` if you do not want to modify the SELinux labels for the SAP directories set
# in variable `sap_general_preconfigure_sap_directories`.

sap_general_preconfigure_size_of_tmpfs_gb: "{{ ((0.75 * (ansible_memtotal_mb + ansible_swaptotal_mb)) / 1024) | round | int }}"
Expand Down
2 changes: 1 addition & 1 deletion roles/sap_general_preconfigure/meta/argument_specs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,7 @@ argument_specs:
sap_general_preconfigure_modify_selinux_labels:
default: true
description:
- Set to `false` if you do not want to modify the SELinux labels for the SAP directores set
- Set to `false` if you do not want to modify the SELinux labels for the SAP directories set
- in variable `sap_general_preconfigure_sap_directories`.
required: false
type: bool
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

# Reasons for noqa: 1. Tabs can increase readability;
# 2. The example in man limits.conf is tab formatted;
# 3. It is difficult to replace tabs by spaces for entries for which their lenghts are not known
# 3. It is difficult to replace tabs by spaces for entries for which their lengths are not known
- name: Set the hard and soft limit for the max number of open files per process (nofile) to 1048576
for group 'sapsys' # noqa no-tabs
ansible.builtin.lineinfile:
Expand All @@ -19,7 +19,7 @@

# Reasons for noqa: 1. Tabs can increase readability;
# 2. The example in man limits.conf is tab formatted;
# 3. It is difficult to replace tabs by spaces for entries for which their lenghts are not known
# 3. It is difficult to replace tabs by spaces for entries for which their lengths are not known
- name: Set the hard and soft limit for the max number of open files per process (nofile) to 1048576
for group '{{ sap_general_preconfigure_db_group_name }}' # noqa no-tabs
ansible.builtin.lineinfile:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

# Reasons for noqa: 1. Tabs can increase readability;
# 2. The example in man limits.conf is tab formatted;
# 3. It is difficult to replace tabs by spaces for entries for which their lenghts are not known
# 3. It is difficult to replace tabs by spaces for entries for which their lengths are not known
- name: Set the hard and soft limit for the max number of processes per user (nproc) to unlimited
for group 'sapsys' # noqa no-tabs
ansible.builtin.lineinfile:
Expand All @@ -19,7 +19,7 @@

# Reasons for noqa: 1. Tabs can increase readability;
# 2. The example in man limits.conf is tab formatted;
# 3. It is difficult to replace tabs by spaces for entries for which their lenghts are not known
# 3. It is difficult to replace tabs by spaces for entries for which their lengths are not known
- name: Set the hard and soft limit for the max number of processes per user (nproc) to unlimited
for group '{{ sap_general_preconfigure_db_group_name }}' # noqa no-tabs
ansible.builtin.lineinfile:
Expand Down
2 changes: 1 addition & 1 deletion roles/sap_general_preconfigure/tasks/sapnote/1771258.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
- name: Configure - Display SAP note number 1771258 and its version
ansible.builtin.debug:
msg: "SAP note {{ (__sap_general_preconfigure_sapnotes_versions | selectattr('number', 'match', '^1771258$') | first).number }}
(version {{ (__sap_general_preconfigure_sapnotes_versions | selectattr('number', 'match', '^1771258$') | first).version }}): User and system resouce limits"
(version {{ (__sap_general_preconfigure_sapnotes_versions | selectattr('number', 'match', '^1771258$') | first).version }}): User and system resource limits"

- name: Import tasks from '../RedHat/generic/increase-nofile-limits.yml'
ansible.builtin.import_tasks: ../RedHat/generic/increase-nofile-limits.yml
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
- name: Assert - Display SAP note number 1771258 and its version
ansible.builtin.debug:
msg: "SAP note {{ (__sap_general_preconfigure_sapnotes_versions | selectattr('number', 'match', '^1771258$') | first).number }}
(version {{ (__sap_general_preconfigure_sapnotes_versions | selectattr('number', 'match', '^1771258$') | first).version }}): User and system resouce limits"
(version {{ (__sap_general_preconfigure_sapnotes_versions | selectattr('number', 'match', '^1771258$') | first).version }}): User and system resource limits"

- name: Import tasks from '../RedHat/generic/assert-nofile-limits.yml'
ansible.builtin.import_tasks: ../RedHat/generic/assert-nofile-limits.yml
Expand Down
4 changes: 2 additions & 2 deletions roles/sap_ha_install_hana_hsr/tasks/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@
that:
- __sap_ha_install_hana_hsr_connection.node_ip is defined
- __sap_ha_install_hana_hsr_connection.node_ip != ""
fail_msg: "The IP adress configured for HSR does not exist on this host"
success_msg: "The IP adress for HSR is configured on this host"
fail_msg: "The IP address configured for HSR does not exist on this host"
success_msg: "The IP address for HSR is configured on this host"
tags: always

- name: "SAP HSR - Pick up primary node name from definition"
Expand Down
4 changes: 2 additions & 2 deletions roles/sap_ha_pacemaker_cluster/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ In addition, the following network ports must be available:

| **SAP Technical Application and Component** | **Port** |
| --- | --- |
| **_SAP HANA Sytem Replication_** | |
| **_SAP HANA System Replication_** | |
| hdbnameserver<br/><sub> used for log and data shipping from a primary site to a secondary site.<br/>System DB port number plus 10,000</sub> | 4`<sap_hana_instance_no>`01 |
| hdbnameserver<br/><sub> unencrypted metadata communication between sites.<br/>System DB port number plus 10,000</sub> | 4`<sap_hana_instance_no>`02 |
| hdbnameserver<br/><sub> used for encrypted metadata communication between sites.<br/>System DB port number plus 10,000</sub> | 4`<sap_hana_instance_no>`06 |
Expand All @@ -95,7 +95,7 @@ In addition, the following network ports must be available:
| **_Linux Pacemaker_** | |
| pcsd<br/><sub> cluster nodes requirement for node-to-node communication</sub> | 2224 (TCP)|
| pacemaker<br/><sub> cluster nodes requirement for Pacemaker Remote service daemon</sub> | 3121 (TCP) |
| corosync<br/><sub> cluster nodes requirement for node-to-node communcation</sub> | 5404-5412 (UDP) |
| corosync<br/><sub> cluster nodes requirement for node-to-node communication</sub> | 5404-5412 (UDP) |

## Execution Flow

Expand Down
2 changes: 1 addition & 1 deletion roles/sap_ha_pacemaker_cluster/defaults/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ sap_ha_pacemaker_cluster_system_roles_collection: 'fedora.linux_system_roles'

# Optional: write all cluster configuration (including unencrypted credentials!) into a yaml
# config file.
# Useful for parameter review or re-use with the 'ha_cluster' LSR.
# Useful for parameter review or reuse with the 'ha_cluster' LSR.
sap_ha_pacemaker_cluster_create_config_varfile: false
sap_ha_pacemaker_cluster_create_config_dest: "review_resource_config.yml"

Expand Down
4 changes: 2 additions & 2 deletions roles/sap_ha_pacemaker_cluster/tasks/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
# 5. Include LSR "ha_cluster" with the constructed parameters as role arguments
# 6. Add solution specific config
# * srhook
# 7. Save LSR "ha_cluster" input parameters in .yml file for easy re-use
# 7. Save LSR "ha_cluster" input parameters in .yml file for easy reuse

# TODO: Build all resource/constraint configuration variables based on
# simpler user input (think: drop-down options in a UI)
Expand Down Expand Up @@ -214,7 +214,7 @@

# Save all the constructed cluster parameters into a vars file.
#
# This will help re-using ha_cluster afterwards without loosing the already
# This will help re-using ha_cluster afterwards without losing the already
# configured resources and constraints.
# The ha_cluster role will otherwise remove configuration that is not part
# of the parameters provided during any subsequent run outside of the current
Expand Down
2 changes: 1 addition & 1 deletion roles/sap_hana_install/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,7 @@ These checks are only performed if `sap_hana_install_force` is set to `true`. It

- If file `hdblcm` is found, skip the next step and proceed with the `hdblcm` existence check.

- If file `hdblcm` ist not found, proceed with the next step.
- If file `hdblcm` is not found, proceed with the next step.

- Prepare SAR files for `hdblcm`:

Expand Down
4 changes: 2 additions & 2 deletions roles/sap_hana_install/defaults/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ sap_hana_install_software_extract_directory: "{{ sap_hana_install_software_direc
# set the value to true. By default, this directory will not be removed
sap_hana_install_cleanup_extract_directory: false

# Set this variabe to `yes` if you want to copy the SAR files from `sap_hana_install_software_directory`
# Set this variable to `yes` if you want to copy the SAR files from `sap_hana_install_software_directory`
# to `sap_hana_install_software_extract_directory/sarfiles` before extracting.
# This might be useful if the SAR files are on a slow fileshare.
sap_hana_install_copy_sarfiles: no
Expand Down Expand Up @@ -59,7 +59,7 @@ sap_hana_install_verify_signature: no
sap_hana_install_configfile_directory: "{{ sap_hana_install_software_extract_directory }}/configfiles"

# If a custom path for sap_hana_install_configfile_directory was defined and if there is a requirement to cleanup this directory,
# then set "sap_hana_install_cleanup_configfile_directory" as true. Incase if a custom path was not defined and
# then set "sap_hana_install_cleanup_configfile_directory" as true. In case if a custom path was not defined and
# "sap_hana_install_cleanup_extract_directory" was set as true, then the configfiles will be removed.
sap_hana_install_cleanup_configfile_directory: false

Expand Down
4 changes: 2 additions & 2 deletions roles/sap_hana_install/tasks/assert-addhosts-loop-block.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
msg: "Instance profile: '/hana/shared/{{ sap_hana_install_sid }}/profile/\
{{ sap_hana_install_sid }}_HDB{{ sap_hana_install_number }}_{{ line_item }}'"

- name: SAP HANA Add Hosts - Assert that there is no instance profile for the addional hosts
- name: SAP HANA Add Hosts - Assert that there is no instance profile for the additional hosts
ansible.builtin.assert:
that: not __sap_hana_install_register_instance_profile_addhost.stat.exists
fail_msg:
Expand All @@ -28,7 +28,7 @@
ansible.builtin.debug:
msg: "Instance directory in /usr/sap: '/usr/sap/{{ sap_hana_install_sid }}/HDB{{ sap_hana_install_number }}/{{ line_item }}'"

- name: SAP HANA Add Hosts - Assert that there is no SAP HANA instance directory in '/usr/sap' for the addional hosts
- name: SAP HANA Add Hosts - Assert that there is no SAP HANA instance directory in '/usr/sap' for the additional hosts
ansible.builtin.assert:
that: not __sap_hana_install_register_usr_sap_instance_directory.stat.exists
fail_msg:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

# Reasons for noqa: 1. Tabs can increase readability;
# 2. The example in man limits.conf is tab formatted;
# 3. It is difficult to replace tabs by spaces for entries for which their lenghts are not known
# 3. It is difficult to replace tabs by spaces for entries for which their lengths are not known
- name: Disable core file creation for all users # noqa no-tabs
ansible.builtin.lineinfile:
path: /etc/security/limits.d/99-sap.conf
Expand Down
5 changes: 2 additions & 3 deletions roles/sap_hana_preconfigure/tasks/sapnote/2009879.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
# We include the release specific stuff here
#

# Todo: move repo checking to RedHat/installion.yml
# Todo: move repo checking to RedHat/installation.yml
# Disable for now, as there is no support for ppc64le
#- name: Check for EUS or E4S repository
# shell: |
Expand All @@ -31,8 +31,7 @@
- name: Configure - Display SAP note number 2009879 and its version
ansible.builtin.debug:
msg: "SAP note {{ (__sap_hana_preconfigure_sapnotes_versions | selectattr('number', 'match', '^2009879$') | first).number }}
(version {{ (__sap_hana_preconfigure_sapnotes_versions | selectattr('number', 'match', '^2009879$') | first).version }}): SAP HANA Guidelines for R
HEL 7 (pdf)"
(version {{ (__sap_hana_preconfigure_sapnotes_versions | selectattr('number', 'match', '^2009879$') | first).version }}): SAP HANA Guidelines for RHEL 7 (pdf)"

- name: Include 2009879_X.yml
ansible.builtin.include_tasks: 2009879_{{ ansible_distribution_major_version }}.yml
4 changes: 2 additions & 2 deletions roles/sap_hana_preconfigure/vars/RedHat_8.yml
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ __sap_hana_preconfigure_min_pkgs: "{{ lookup('vars', '__sap_hana_preconfigure_mi
__sap_hana_preconfigure_packages:
# SAP NOTE 2772999:
- expect
# package graphwiz: graph visualization toos, for supportability)
# package graphwiz: graph visualization tools, for supportability)
- graphviz
# package iptraf-ng: TCP/IP network monitor, for supportability)
- iptraf-ng
Expand Down Expand Up @@ -231,7 +231,7 @@ __sap_hana_preconfigure_packages:
__sap_hana_preconfigure_packages_min_install:
# SAP NOTE 2772999:
- expect
# package graphwiz: graph visualization toos, for supportability)
# package graphwiz: graph visualization tools, for supportability)
# - graphviz
# package iptraf-ng: TCP/IP network monitor, for supportability)
# - iptraf-ng
Expand Down
4 changes: 2 additions & 2 deletions roles/sap_hana_preconfigure/vars/RedHat_9.yml
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ __sap_hana_preconfigure_packages:
# package libxcrypt-compat: needed SAP HANA and also by sapstartsrv on RHEL 9:
# - libxcrypt-compat # now installed by role sap_general_preconfigure, see also SAP note 3108316, version 4.
# For support purposes:
# package graphwiz: graph visualization toos, for supportability)
# package graphwiz: graph visualization tools, for supportability)
- graphviz
# package iptraf-ng: TCP/IP network monitor, for supportability)
- iptraf-ng
Expand Down Expand Up @@ -226,7 +226,7 @@ __sap_hana_preconfigure_packages_min_install:
# required for SAP HANA on RHEL 9:
- libxcrypt-compat
# For support purposes:
# package graphwiz: graph visualization toos, for supportability)
# package graphwiz: graph visualization tools, for supportability)
# - graphviz
# package iptraf-ng: TCP/IP network monitor, for supportability)
# - iptraf-ng
Expand Down
4 changes: 2 additions & 2 deletions roles/sap_hostagent/CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,10 @@ According to SAP Note the command is: saphostexec -upgrade
- get the installable Version
- install/upgrade if required

### Important Steps from the documention:
### Important Steps from the documentation:

- requires root
- Optional Paramter: `-pf <ProfilePath>` defaults to /usr/sap/exe
- Optional Parameter: `-pf <ProfilePath>` defaults to /usr/sap/exe

1. Install Host agent (from unpacked directory)
```
Expand Down
Loading

0 comments on commit 7cdb7b9

Please sign in to comment.