Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sap_swpm: No longer require module community.general.pids #719

Closed
berndfinger opened this issue Apr 18, 2024 · 1 comment
Closed

sap_swpm: No longer require module community.general.pids #719

berndfinger opened this issue Apr 18, 2024 · 1 comment
Assignees
@berndfinger

Comments

@berndfinger
Copy link
Member

berndfinger commented Apr 18, 2024 •
edited by sean-freeman
Loading

We should be able to replace community.general.pid by ps -ef and awk processing using the ansible.builtin.shell module. The goal is mainly to avoid installing some Python related package and module installations and to simplify support for the downstream collection version.
@berndfinger berndfinger self-assigned this Apr 18, 2024
berndfinger added a commit to berndfinger/community.sap_install that referenced this issue Apr 18, 2024
@berndfinger
sap_swpm: Minor tweaks
59a21d5 
Relates to sap-linuxlab#716 and sap-linuxlab#719.

Signed-off-by: Bernd Finger <[email protected]>
@berndfinger berndfinger mentioned this issue Apr 18, 2024
Closed
berndfinger added a commit to berndfinger/community.sap_install that referenced this issue Apr 18, 2024
@berndfinger
sap_swpm: Solve ansible-lint errors
74af762 
Relates to sap-linuxlab#719.

Signed-off-by: Bernd Finger <[email protected]>
berndfinger added a commit to berndfinger/community.sap_install that referenced this issue Apr 18, 2024
@berndfinger
sap_swpm: Improve the sapinst command pattern
ef02f9f 
Relates to sap-linuxlab#719.

Signed-off-by: Bernd Finger <[email protected]>
@berndfinger berndfinger changed the title sap_swpm: No longer require module community.general.pid sap_swpm: No longer require module community.general.pids May 6, 2024
berndfinger added a commit to berndfinger/community.sap_install that referenced this issue Jun 24, 2024
@berndfinger
sap_swpm: Remove the pids module
58b2974 
Solves issue sap-linuxlab#719.

Signed-off-by: Bernd Finger <[email protected]>
@berndfinger berndfinger mentioned this issue Jun 27, 2024
Merged
@berndfinger
Copy link
Member Author

Solved in #786 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@berndfinger berndfinger

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@berndfinger