Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sap_swpm: Remove the pids module #786

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

berndfinger
Copy link
Member

This PR is a essentially a reopening of #720 after version 1.4.1 has been published.
Solves issue #719.

Advantages:

  • No dependency on community.general in the role sap_swpm, simplifying support for downstream versions
  • No more Python related package installations at the beginning of the role

Solves issue sap-linuxlab#719.

Signed-off-by: Bernd Finger <[email protected]>
Copy link
Contributor

@marcelmamula marcelmamula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@sean-freeman sean-freeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@berndfinger berndfinger merged commit c8762a9 into sap-linuxlab:dev Jul 5, 2024
3 of 4 checks passed
@berndfinger berndfinger deleted the issue-719-after-v141 branch July 5, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants