Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sap_maintain_etc_hosts: Fix wrong assert messages #668

Merged
merged 3 commits into from
Mar 4, 2024
Merged

sap_maintain_etc_hosts: Fix wrong assert messages #668

merged 3 commits into from
Mar 4, 2024

Conversation

berndfinger
Copy link
Member

Also fixes some typos.

Solves issue #662.

@berndfinger berndfinger mentioned this pull request Feb 29, 2024
Merged
rhmk
rhmk approved these changes Mar 4, 2024
View reviewed changes
Copy link
Member

@rhmk rhmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general this looks good. If the commented code lines do not enforce a lint error any more, I am fine with merging

@berndfinger
Copy link
Member Author

In general this looks good. If the commented code lines do not enforce a lint error any more, I am fine with merging
Maybe it's related to the ansible-lint version you have used. The GitHub actions are also clean, so that should be all fine.

@berndfinger berndfinger merged commit ee8e78d into sap-linuxlab:dev Mar 4, 2024
4 checks passed
@berndfinger berndfinger mentioned this pull request Mar 4, 2024
Closed
@berndfinger berndfinger deleted the issue-662 branch March 8, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhmk rhmk rhmk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@berndfinger @rhmk