sap_hana_install: Add support for fapolicyd #727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also use role parameters for /hana and /hana/shared where possible. Signed-off-by: Bernd Finger <[email protected]>
... for the name of the fapolicyd trusted files file. Signed-off-by: Bernd Finger <[email protected]>
... if fapolicyd is to be used. Also replace yes by true and no by false in defaults/main.yml. Signed-off-by: Bernd Finger <[email protected]>
Signed-off-by: Bernd Finger <[email protected]>
Signed-off-by: Bernd Finger <[email protected]>
Signed-off-by: Bernd Finger <[email protected]>
- Add all files with mime type pattern '/x-' - Support more than one directory which contains executable files - Use a separate fapolicyd trust file for each directory Signed-off-by: Bernd Finger <[email protected]>
Signed-off-by: Bernd Finger <[email protected]>
- add support for setting the fapolicyd integrity levels default: sha256 - use /hana/shared and /usr/sap for the directories to be scanned - rename parameter sap_hana_install_directories_with_executables to sap_hana_install_fapolicyd_trusted_directories - reduce line lengths in some cases Signed-off-by: Bernd Finger <[email protected]>
... for the paths to be searched for executables, so the paths are identical to those used to set the file contexts for SELinux Signed-off-by: Bernd Finger <[email protected]>
Signed-off-by: Bernd Finger <[email protected]>
Signed-off-by: Bernd Finger <[email protected]>
Signed-off-by: Bernd Finger <[email protected]>
...after modifying the fapolicyd config file Signed-off-by: Bernd Finger <[email protected]>
Signed-off-by: Bernd Finger <[email protected]>
Signed-off-by: Bernd Finger <[email protected]>
Signed-off-by: Bernd Finger <[email protected]>
Signed-off-by: Bernd Finger <[email protected]>
Signed-off-by: Bernd Finger <[email protected]>
Signed-off-by: Bernd Finger <[email protected]>
Signed-off-by: Bernd Finger <[email protected]>
Signed-off-by: Bernd Finger <[email protected]>
... for multiple directories Signed-off-by: Bernd Finger <[email protected]>
... and some further tweaking Signed-off-by: Bernd Finger <[email protected]>
rhmk
reviewed
Jun 7, 2024
rhmk
requested changes
Jun 7, 2024
…aults/main.yml Signed-off-by: Bernd Finger <[email protected]>
Signed-off-by: Bernd Finger <[email protected]>
Signed-off-by: Bernd Finger <[email protected]>
Thanks for your review! All good now (I hope). |
- We use sap_hana_install_shared_path in favor of sap_hana_install_install_path - If present (e.g. in playbooks or inventories), we use the first directory component of sap_hana_install_install_path for sap_hana_install_root_path and we assign sap_hana_install_install_path to sap_hana_install_shared_path. Examples: If sap_hana_install_install_path is defined as '/hana_01/shared', the following variables will be set: sap_hana_install_root_path.: '/hana_01' sap_hana_install_shared_path: '/hana_01/shared' If sap_hana_install_install_path is not defined, the following variables will be set: sap_hana_install_root_path.: '/hana' sap_hana_install_shared_path: '/hana/shared' Signed-off-by: Bernd Finger <[email protected]>
sean-freeman
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for fapolicyd:
fapolicydis ensured./etc/fapolicyd/fapolicyd.confwill besha256instead of the defaultnone./etc/faplicyd/rules.d, for protecting shell scripts, is ensured./hanaand/usr/sapin fapolicyd trust files in/etc/faplicyd/trust.dis ensured.fapolicydis enabled and running.I introduced a new role parameter,
sap_hana_install_root_pathwhich is needed for this functionality, and replaced/hanaby this variable and/hana/sharedby its corresponding variable.I also modified
yes/nototrue/falseindefaults/main.ymlso we over time only use those for all roles.Solves #728.