sap_ swpm: Prevent task "SAP SWPM Deployment - Finished" from failing if sap_swpm_sid or sap_swpm_pas_instance_nr not defined. #746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
failing if sap_swpm_sid or sap_swpm_pas_instance_nr not defined.
rob0d
changed the title
rob0d
changed the title
|
@berndfinger This looks like reasonable change by defaulting them, instead of adding whole conditional for final debug message. |
berndfinger
reviewed
Jun 10, 2024
Wabri
reviewed
Jun 12, 2024
Wabri
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This happens when using advanced mode (e.g. Diag Agent installation) and sap_swpm_* variables are not defined as they are not needed. These two are used to display the status of SWPM after it finished and can fail the whole playbook even though SWPM finished correctly.