sap_facts.sh - ps print only executable with path #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
collection: merge dev to main for release 0.9.1
collection: merge dev to main for release 0.9.1 fix
jhohwieler
force-pushed
the
sap_facts.sh-ps-command-column
branch
2 times, most recently
from
9140fd1
to
46d9216
Compare
jhohwieler
changed the title
The output of "ps -ef" not also includes the command but also the process age and process arguments. Both can have digits in its string which may interfere when grepping for an instance number like 00 or 01. To fix this, let ps print only the executable with its path. Example: ps with default output - 2 lines match where only 1st line should match /usr/sap/A22/D01/exe/sapstartsrv pf=/usr/sap/A22/SYS/profile/A22_D01_sapa22u01 -D -u a22adm /usr/sap/A22/ASCS02/exe/sapstartsrv pf=/usr/sap/A22/SYS/profile/A22_ASCS02_sapa22u01 -D -u a22adm Example: ps with custom layout, only one line matches as expected /usr/sap/A22/D01/exe/sapstartsrv
jhohwieler
force-pushed
the
sap_facts.sh-ps-command-column
branch
from
46d9216
to
8ee8993
Compare
Wabri
approved these changes
Aug 20, 2024
|
It's almost two months ago since I opened this pull request. Is there a timeline to get this change mainline? |
rainerleber
approved these changes
Oct 18, 2024
There was a problem hiding this comment.
lgtm
maybe you should have a look at community.sap_libs.sap_system_facts
https://docs.ansible.com/ansible/latest/collections/community/sap_libs/sap_system_facts_module.html
|
or maybe have a look at sap.sap_operations.host_info module |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was wondering why the gathering of SAP facts was unstable. While digging through the sap_facts.sh script, I've figured that there is an issue with the ps command output. The name of the SAP instances, like 00 or 01 etc., can interfere with the process age or even with arguments.
I had to revise my code change. At first I used "ps -eo command" to prevent any interference with the process age. But later I figured it can also interfere with arguments. So I revised my patch to use "ps -eo exe".