-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add query management functionality #1
base: main
Are you sure you want to change the base?
Conversation
Add QueryExecutor object and split query logic -> Update Query object
Provide `Query`, `QueryManager`, `QueryExecutor`, `QuerySplitter` and `DataCleaner` objects directly
Apply query logic changes and update thread handling | Add time measuring
for query_uuid in query_uuids: | ||
if len(qm.queues[query_uuid].query_objects) == 0: | ||
continue | ||
qm.queues[query_uuid].schedule_queries() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can be expressed as list comprehension.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[
qm.queues[query_uuid].schedule_queries()
for query_uuid in query_uuids
if not len(qm.queues[query_uuid].query_objects) == 0
]
Produces the following linting note:
Expression "[qm.queues[query_uuid].schedule_queries() for query_uuid in query_uuids if not len(qm.queues[query_uuid].query_objects) == 0]" is assigned to nothing | Pylint(W0106:expression-not-assigned)
Co-authored-by: Sandro <[email protected]>
Due to: #1 (comment) and #1 (comment)
Due to: #1 (comment)
Due to: #1 (comment)
Due to: #1 (comment)
Co-authored-by: Sandro <[email protected]>
Due to: #1 (comment)
Co-authored-by: Sandro <[email protected]>
Co-authored-by: Sandro <[email protected]>
Co-authored-by: Sandro <[email protected]>
Co-authored-by: Sandro <[email protected]>
Co-authored-by: Sandro <[email protected]>
Due to: #1 (comment)
Co-authored-by: Sandro <[email protected]>
Co-authored-by: Sandro <[email protected]>
Co-authored-by: Sandro <[email protected]>
Due to: #1 (comment)
Co-authored-by: Sandro <[email protected]>
Due to: #1 (comment)
Co-authored-by: Sandro <[email protected]>
Due to: #1 (comment)
Co-authored-by: SuperSandro2000 <[email protected]>
Goal
How I try to achieve this goal