openstack-seeder: allow ignoring or focusing on multiple namespaces #6597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This requires the patch from <sapcc/kubernetes-operators#105> to be applied.
majewsky
requested review from
stefanhipfel,
databus23 and
fwiesel
as code owners
stefanhipfel
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires the patch from sapcc/kubernetes-operators#105 to be applied.
I chose to leave
ignoreNamespaceandonlyNamespaceas stringly-typed for backwards compatibility with the existing regional values files. If desired, I can also change this to take array arguments, in which case slightly more care needs to merge and deploy this and the respective secrets PR at the same time.I tested this with
helm diff upgradein eu-de-2 (both normal and global deployment) and saw the desired diff.