Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pxc-operator] Don't set unnecessary prometheus.io/scrape annotation #7576

Merged
merged 1 commit into from
Dec 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion system/percona-xtradb-cluster-operator/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ name: percona-xtradb-cluster-operator
description: A Helm chart to install Percona XtraDB Cluster Operator.
home: "https://github.com/sapcc/helm-charts/tree/master/system/percona-xtradb-cluster-operator"
type: application
version: 0.2.2
version: 0.2.3
appVersion: "1.15.1"
kubeVersion: ">=1.26.0-0"
maintainers:
Expand Down
3 changes: 2 additions & 1 deletion system/percona-xtradb-cluster-operator/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ kube-state-metrics:
registry: keppel.global.cloud.sap/ccloud-registry-k8s-io-mirror
repository: kube-state-metrics/kube-state-metrics
rbac:
create: true # NOTE: need to create a custom role instead with access only to custom resources
create: true # only a limited role is created, because all collectors are disabled, except custom-resource-state
extraRules:
- apiGroups: ["pxc.percona.com"]
resources:
Expand All @@ -114,6 +114,7 @@ kube-state-metrics:

selfMonitor:
enabled: true
prometheusScrape: false # don't set prometheus.io/scrape annotation on kube-state-metrics service, because we use ServiceMonitor

collectors: null

Expand Down
Loading