add type nova.FlavorSelection #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will be reused with the upcoming other Nova capacity plugin, and also this will need a denylist soon. I'm also moving the HypervisorTypeRx and AggregateNameRx into a subsection because the same splitting of a type will happen there later.
majewsky
force-pushed
the
flavor-selection
branch
2 times, most recently
from
64cc3f2 to
c25f4a2
Compare
Similar to nova.FlavorSelection that was added in the last commit, this makes a large chunk of the "nova" capacity plugin reusable for the other upcoming compute capacity plugin.
majewsky
force-pushed
the
flavor-selection
branch
from
c25f4a2 to
f72dca6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be reused with the upcoming other Nova capacity plugin, and also this will need a denylist soon.
Please merge this together with the respective PR in the secrets repo.