Acpq quota overrides bug #654
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Varsius
commented
Feb 4, 2025
Varsius
force-pushed
the
acpq-quota-overrides-bug
branch
from
1c277c9 to
ffd0710
Compare
Varsius
requested review from
SuperSandro2000,
VoigtS and
Nuckal777
as code owners
majewsky
requested changes
Feb 6, 2025
| } | ||
|
|
||
| func TestMinQuotaConstraintWithLargeNumbers(t *testing.T) { | ||
| // This tests how min quota overwrites deals with very large numbers |
There was a problem hiding this comment.
Typo:
Suggested change
| // This tests how min quota overwrites deals with very large numbers | |
| // This tests how min quota overrides deals with very large numbers |
| // Quota should not be assgined to ANY AZ on AZ aware resources. This causes unusable quota distribution on manual quota overrides. | ||
| resourceAZs := allAZs | ||
| if isAZAware { | ||
| resourceAZs = append([]limes.AvailabilityZone{}, allAZs...) |
There was a problem hiding this comment.
This used to be the idiomatic way to clone a slice, but a standard library function has been added recently:
Suggested change
| resourceAZs = append([]limes.AvailabilityZone{}, allAZs...) | |
| resourceAZs = slices.Clone(allAZs) |
| } | ||
| } | ||
| } | ||
| missingQuota := subtractOrZero(*c.MinQuota, totalAllocated) |
There was a problem hiding this comment.
This made me notice that we have another instance of subtract-or-zero here. While we're at it, please replace subtractOrZero() with liquidapi.SaturatingSub() to reduce code duplication.
Comment on lines
+474
to
+476
| if az == limes.AvailabilityZoneAny && isAZAware { | ||
| continue | ||
| } |
There was a problem hiding this comment.
Is this check necessary? When initializing resourceAZs at the top of the function, we already filter out any if isAZAware.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist: