fix race in share network delete #236
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We iterate over the share network subnets, send rpc calls to delete their share servers and then remove the share network subnet and the share network from the db by using soft delete. The info from those models is still required to deallocate the network in the driver, e.g. the neutron plugin needs the neutron net info. We don't want the API layer of share network delete to be blocked waiting for share server deletion, instead we look at the soft deleted data in the manager handling the share server deletion. This usually happens shortly after the soft deletion was done, so we should still be able to find the entries. Change-Id: I1f23b9e93316cabb7bd32be7bb9b63dbd4eb889f
Carthaca
requested review from
chuan137,
kpawar-sap,
sumitarora2786 and
crenduchinta88
as code owners
kpawar-sap
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We iterate over the share network subnets, send rpc calls to delete
their share servers and then remove the share network subnet and the
share network from the db by using soft delete.
The info from those models is still required to deallocate the
network in the driver, e.g. the neutron plugin needs the neutron
net info.
We don't want the API layer of share network delete to be blocked
waiting for share server deletion, instead we look at the soft deleted
data in the manager handling the share server deletion.
This usually happens shortly after the soft deletion was done, so we
should still be able to find the entries.
Change-Id: I1f23b9e93316cabb7bd32be7bb9b63dbd4eb889f