Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a custom designate driver for FIP's #70

Open
wants to merge 16 commits into
base: stable/yoga-m3
Choose a base branch
from
Open

Use a custom designate driver for FIP's #70

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
b44f3e7
[designate] Add custom dns driver for FIP's
misamoylov Jan 13, 2025
8534d81
Update after review
misamoylov Jan 30, 2025
20d9ba7
Update after review
misamoylov Feb 2, 2025
63351f8
Add custom FIP DNS driver. Address review
misamoylov Feb 12, 2025
27fce56
Add custom FIP DNS driver. Address review
misamoylov Feb 21, 2025
e3650c8
Add custom FIP DNS driver. Address review
misamoylov Feb 24, 2025
63382b9
Update
misamoylov Feb 26, 2025
c0e587c
Update
misamoylov Feb 26, 2025
f00f1eb
Update tests
misamoylov Feb 26, 2025
63ec657
Update tests
misamoylov Feb 26, 2025
79d56ac
Update tests
misamoylov Feb 26, 2025
65d1256
Update tests
misamoylov Feb 26, 2025
ca23bc0
Update tests
misamoylov Feb 26, 2025
a408d7c
Update tests
misamoylov Feb 26, 2025
577f3e0
Update copyrights and delete unused method in driver
misamoylov Mar 10, 2025
e44bf90
Update copyrights and delete unused method in driver
misamoylov Mar 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion neutron/db/dns_db.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,6 @@ def _process_dns_floatingip_delete(self, context, floatingip_data):
return
dns_data_db = fip_obj.FloatingIPDNS.get_object(
context, floatingip_id=floatingip_data['id'])

if dns_data_db:
self._delete_floatingip_from_external_dns_service(
context, dns_data_db['published_dns_domain'],
Expand Down
17 changes: 16 additions & 1 deletion neutron/services/externaldns/drivers/designate/driver_ccloud.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Copyright (c) 2016 IBM
# Copyright (c) 2025 SAP SE
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copyright is cumulative (i.e. as long as we keep some of the original code, the original's author still applies to that part of the code).
So please don't remove IBMs copyright, but instead add ours next to it, else this would be an IP infringement.
(Needed only for files that we actually change.)

# All Rights Reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License"); you may
Expand Down Expand Up @@ -102,6 +102,21 @@ def __init__(self):

def create_record_set(self, context, dns_domain, dns_name, records,
fip_id=None):
"""Create a record set in the specified zone.

:param context: neutron api request context
:type context: neutron_lib.context.Context
:param dns_domain: the dns_domain where the record set will be created
:type dns_domain: String
:param dns_name: the name associated with the record set
:type dns_name: String
:param records: the records in the set
:type records: List of Strings
:param fip_id: Floating IP id
:type fip_id: String
:raises: neutron.extensions.dns.DNSDomainNotFound
neutron.extensions.dns.DuplicateRecordSet
"""
designate, designate_admin = get_clients(context)
v4, v6 = self._classify_records(records)
try:
Expand Down
Loading