Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update picas examples and token commands #21

Merged
merged 32 commits into from
Dec 10, 2024
Merged

Update picas examples and token commands #21

merged 32 commits into from
Dec 10, 2024

Conversation

xinan1911
Copy link
Contributor

edit README.md

examples/deleteTokens.py Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@natalieda natalieda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to revise the example to be workable and easier to follow. My recommendation is to split the quick and fractals example in different sections and execute each one locally, using slurm and on the grid. For both examples the necessary files should be fetched from the Github repo and not from the Grid docs tarballs.

@xinan1911
Copy link
Contributor Author

@hailihu This is ready for review. And if everything is okay, then for merging.

README.md Outdated Show resolved Hide resolved
@hailihu
Copy link
Collaborator

hailihu commented Nov 14, 2024

I suggest to revise the example to be workable and easier to follow. My recommendation is to split the quick and fractals example in different sections and execute each one locally, using slurm and on the grid. For both examples the necessary files should be fetched from the Github repo and not from the Grid docs tarballs.

It seems that you have not implemented this recommendation (totally) yet. In particular, there are still links to the Grid docs tarballs for downloads that do not work.

Copy link
Collaborator

@hailihu hailihu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some changes and fixes needed.

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
docs/fractal-example.md Outdated Show resolved Hide resolved
docs/fractal-example.md Outdated Show resolved Hide resolved
docs/fractal-example.md Outdated Show resolved Hide resolved
docs/fractal-example.md Outdated Show resolved Hide resolved
@hailihu hailihu requested a review from laloffredo December 4, 2024 14:18
Increase max_token_time for long example
@hailihu hailihu merged commit d1a674d into master Dec 10, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants