Merge pull request openedx#120 from openedx/cag/problem-link

fix: use name with location as link text
saraburns1 · Sep 11, 2024 · 8824334 · 8824334
2 parents c880bec + a1cae36
commit 8824334
Show file tree

Hide file tree

Showing 8 changed files with 4,285 additions and 4,281 deletions.
diff --git a/models/problems/fact_problem_responses.sql b/models/problems/fact_problem_responses.sql
@@ -24,7 +24,8 @@ select
     responses.problem_id as problem_id,
     blocks.block_name as problem_name,
     blocks.display_name_with_location as problem_name_with_location,
-    {{ a_tag("responses.object_id", "blocks.block_name") }} as problem_link,
+    {{ a_tag("responses.object_id", "blocks.display_name_with_location") }}
+    as problem_link,
     blocks.graded as graded,
     course_order as course_order,
     responses.actor_id as actor_id,

diff --git a/models/problems/int_problem_results.sql b/models/problems/int_problem_results.sql
@@ -33,7 +33,8 @@ select
     blocks.block_name as problem_name,
     blocks.display_name_with_location as problem_name_with_location,
     blocks.course_order as course_order,
-    {{ a_tag("full_responses.object_id", "blocks.block_name") }} as problem_link,
+    {{ a_tag("full_responses.object_id", "blocks.display_name_with_location") }}
+    as problem_link,
     full_responses.actor_id as actor_id,
     full_responses.responses as responses,
     full_responses.success as success,

diff --git a/models/problems/section_problem_engagement.sql b/models/problems/section_problem_engagement.sql
@@ -33,7 +33,8 @@ with
             responses.problem_id as problem_id,
             blocks.block_name as problem_name,
             blocks.display_name_with_location as problem_name_with_location,
-            {{ a_tag("responses.object_id", "blocks.block_name") }} as problem_link,
+            {{ a_tag("responses.object_id", "blocks.display_name_with_location") }}
+            as problem_link,
             blocks.graded as graded,
             course_order as course_order,
             responses.actor_id as actor_id,

diff --git a/models/problems/subsection_problem_engagement.sql b/models/problems/subsection_problem_engagement.sql
@@ -33,7 +33,8 @@ with
             responses.problem_id as problem_id,
             blocks.block_name as problem_name,
             blocks.display_name_with_location as problem_name_with_location,
-            {{ a_tag("responses.object_id", "blocks.block_name") }} as problem_link,
+            {{ a_tag("responses.object_id", "blocks.display_name_with_location") }}
+            as problem_link,
             blocks.graded as graded,
             course_order as course_order,
             responses.actor_id as actor_id,

diff --git a/models/video/fact_video_plays.sql b/models/video/fact_video_plays.sql
@@ -25,7 +25,7 @@ select
     plays.video_id as video_id,
     blocks.block_name as video_name,
     blocks.display_name_with_location as video_name_with_location,
-    {{ a_tag("plays.object_id", "blocks.block_name") }} as video_link,
+    {{ a_tag("plays.object_id", "blocks.display_name_with_location") }} as video_link,
     blocks.graded as graded,
     plays.video_position as video_position,
     plays.video_duration as video_duration,

diff --git a/unit-test-seeds/problems/fact_problem_responses_expected.csv b/unit-test-seeds/problems/fact_problem_responses_expected.csv
diff --git a/unit-test-seeds/problems/int_problem_results_expected.csv b/unit-test-seeds/problems/int_problem_results_expected.csv
diff --git a/unit-test-seeds/video/fact_video_plays_expected.csv b/unit-test-seeds/video/fact_video_plays_expected.csv