Merge pull request openedx#128 from saraburns1/negative_video_perc

fix: Exclude negative percents
saraburns1 · Oct 23, 2024 · ee5b022 · ee5b022
2 parents ff18ca9 + 9e6acd3
commit ee5b022
Show file tree

Hide file tree

Showing 2 changed files with 147 additions and 205 deletions.
diff --git a/models/video/watched_video_duration.sql b/models/video/watched_video_duration.sql
@@ -62,7 +62,9 @@ with
             and starts.course_key = ends.course_key
             and starts.video_id = ends.video_id
             and starts.actor_id = ends.actor_id
-        where starts.emission_time < ends.emission_time
+        where
+            starts.emission_time < ends.emission_time
+            and starts.start_position < ends.end_position
     ),
     range as (select * from range_multi where rownum = 1),
     rewatched as (